newrelic / newrelic-python-agent

New Relic Python Agent
https://docs.newrelic.com/docs/agents/python-agent
Apache License 2.0
178 stars 102 forks source link

Update loguru hook to include milliseconds in timestamp #1149

Closed julia-tadej-wttech closed 5 months ago

julia-tadej-wttech commented 5 months ago

This PR fixes timestamp for loguru logs. Currently, milliseconds for log records coming from loguru are always equal to 0. After this change, milliseconds will be recorded correctly (so the log order will be correct).

CLAassistant commented 5 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: julia-tadej-wttech
:x: mergify[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.43%. Comparing base (8b79e6c) to head (2cb95ab).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1149 +/- ## ========================================== - Coverage 81.45% 81.43% -0.02% ========================================== Files 192 192 Lines 21345 21345 Branches 3715 3715 ========================================== - Hits 17387 17383 -4 - Misses 2869 2872 +3 - Partials 1089 1090 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TimPansino commented 5 months ago

Thanks @julia-tadej-wttech, we'll get this into the next release.