newrelic / newrelic-python-agent

New Relic Python Agent
https://docs.newrelic.com/docs/agents/python-agent
Apache License 2.0
176 stars 99 forks source link

Psycopg3 Instrumentation #1155

Closed TimPansino closed 3 months ago

TimPansino commented 3 months ago

Overview

github-actions[bot] commented 3 months ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 4 0 5.53s
✅ PYTHON black 20 0 0 2.5s
✅ PYTHON flake8 20 0 1.14s
✅ PYTHON isort 20 0 0 0.39s
✅ PYTHON pylint 20 0 8.69s
✅ YAML prettier 1 0 0 1.41s
✅ YAML v8r 1 0 2.91s
✅ YAML yamllint 1 0 0.5s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 89.27445% with 34 lines in your changes missing coverage. Please review.

Project coverage is 81.63%. Comparing base (60c5549) to head (38bada0).

Files Patch % Lines
newrelic/hooks/database_dbapi2_async.py 77.77% 15 Missing and 1 partial :warning:
newrelic/hooks/database_psycopg.py 93.42% 5 Missing and 10 partials :warning:
newrelic/hooks/database_dbapi2.py 80.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1155 +/- ## ========================================== + Coverage 81.39% 81.63% +0.24% ========================================== Files 193 195 +2 Lines 21341 21639 +298 Branches 3721 3777 +56 ========================================== + Hits 17370 17666 +296 + Misses 2877 2871 -6 - Partials 1094 1102 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TimPansino commented 3 months ago

I definitely feel like a few of the lines of missed coverage are being run, maybe they're not picked up due to something in coverage. I'll check that out on Monday.