newrelic / newrelic-python-agent

New Relic Python Agent

https://docs.newrelic.com/docs/agents/python-agent

Apache License 2.0

176 stars 99 forks source link

Adds instrumentation for aiomcache #1173

Closed jairhenrique closed 2 months ago

jairhenrique commented 3 months ago

_Before contributing, please read our contributing guidelines and code of conduct._

Overview

Adds support to aiomcache instrumentation.

Related Github Issue

Include a link to the related GitHub issue, if applicable

Testing

The agent includes a suite of tests which should be used to verify your changes don't break existing functionality. These tests will run with Github Actions when a pull request is made. More details on running the tests locally can be found here, For most contributions it is strongly recommended to add additional tests which exercise your changes.

CLAassistant commented 3 months ago

All committers have signed the CLA.

jairhenrique commented 2 months ago

@TimPansino @lrafeei I tried to replicate the bmcache tests, but I couldn't understand why the tests are failing. Can you guide me?

lrafeei commented 2 months ago

Hello @jairhenrique --Thanks for the submission! As for the test failures, it’s just a typo causing the issue. In lines 53 and 91 in tests/datastore_aiomemcache/test_aiomemcache.py, the expected transaction metric is set to test_aiomcache:test_... and the filename is test_aiomemcache.py—to stay consistent, let’s change the filename to test_aiomcache.py

jairhenrique commented 2 months ago

@lrafeei thanks!! I ran the tests locally and they now pass!