search

newrelic / newrelic-python-agent

New Relic Python Agent
https://docs.newrelic.com/docs/agents/python-agent
Apache License 2.0
176 stars 99 forks source link

Instrument s3transfer BoundExecutor submit function. #1185

Closed umaannamalai closed 1 month ago

umaannamalai commented 2 months ago

This PR instruments the Instrument s3transfer BoundExecutor submit function. This supports context propagation so that the agent is able to instrument upload_file in boto3.

Closes #1178.

github-actions[bot] commented 2 months ago

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 2 0 5.32s
✅ PYTHON black 4 0 0 1.73s
❌ PYTHON flake8 4 2 0.99s
✅ PYTHON isort 4 1 0 0.37s
✅ PYTHON pylint 4 0 6.5s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.63%. Comparing base (772adec) to head (8d0c705). Report is 2 commits behind head on main.

Files Patch % Lines
newrelic/hooks/external_s3transfer.py 78.57% 1 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1185 +/- ## ========================================== + Coverage 81.40% 81.63% +0.23% ========================================== Files 196 197 +1 Lines 21735 21750 +15 Branches 3795 3797 +2 ========================================== + Hits 17693 17756 +63 + Misses 2937 2889 -48 Partials 1105 1105 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.