search

newrelic / newrelic-python-agent

New Relic Python Agent
https://docs.newrelic.com/docs/agents/python-agent
Apache License 2.0
178 stars 102 forks source link

Adds Valkey support #1234

Closed jairhenrique closed 2 weeks ago

jairhenrique commented 1 month ago

_Before contributing, please read our contributing guidelines and code of conduct._

Overview

Adds support to Valkey an opensource fork of Redis.

Related Github Issue

Include a link to the related GitHub issue, if applicable

Testing

The agent includes a suite of tests which should be used to verify your changes don't break existing functionality. These tests will run with Github Actions when a pull request is made. More details on running the tests locally can be found here, For most contributions it is strongly recommended to add additional tests which exercise your changes.

CLAassistant commented 1 month ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: hmstepanek
:white_check_mark: jairhenrique
:x: mergify[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

jairhenrique commented 3 weeks ago

Hey @jairhenrique thanks for adding support for this! It looks like you copy modified from redis which makes sense since Valkey is based on Redis. I need to spin up a local version of Valkey to test it out manually but I had a couple immediate things I noticed so wanted to get that feedback back to you sooner rather than later. I also made a couple commits on here to get the tests running.

That's right @hmstepanek, I made a copy of redis and removed some unnecessary checks. The valkey project has forked the core redis libraries for nodejs and python, but they are working on an agnostic project called valkey-glide (rust) with bindings for those languages. I think in the future valkey-glide will be the core library for "all languages". It would be cool if you guys had this on your radar.