search

newrelic / newrelic-python-agent

New Relic Python Agent
https://docs.newrelic.com/docs/agents/python-agent
Apache License 2.0
178 stars 102 forks source link

Add cloud.aws.account_id config setting #1249

Open hmstepanek opened 1 week ago

hmstepanek commented 1 week ago

Overview

Add cloud.aws.account_id configuration setting. This is not used in this PR but will be used in future AWS linking for the user to provide the account_id when it cannot be derived by the instrumentation. See the Entity-Relationships agent spec.

github-actions[bot] commented 1 week ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 2 0 5.81s
✅ PYTHON black 2 0 0 2.13s
✅ PYTHON flake8 2 0 1.27s
✅ PYTHON isort 2 0 0 0.36s
✅ PYTHON pylint 2 0 8.01s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.24%. Comparing base (a5d0de3) to head (0d44fc2).

Files with missing lines Patch % Lines
newrelic/core/config.py 52.94% 6 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1249 +/- ## ========================================== - Coverage 81.26% 81.24% -0.03% ========================================== Files 200 200 Lines 21913 21931 +18 Branches 3472 3474 +2 ========================================== + Hits 17807 17817 +10 - Misses 2960 2965 +5 - Partials 1146 1149 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.