search

newrelic / newrelic-python-agent

New Relic Python Agent
https://docs.newrelic.com/docs/agents/python-agent
Apache License 2.0
168 stars 98 forks source link

Support for grpcio-aio (Async gRPC) #330

Open synackSA opened 2 years ago

synackSA commented 2 years ago

Is your feature request related to a problem? Please describe.

We're currently in the process of moving from our PHP based Legacy/Monolith system to a Python based Micro-services environment with a React Micro-frontend. We've been using New Relic for our performance monitoring, logging, alerts, profiling, problem debugging, etc. We've been noticing that we're having performance issues with our services at high traffic load and have been looking at ways to improve performance. One of the things that was identified that would improve performance, would be switching from using synchronous grpc to asynchronous grpc (https://grpc.github.io/grpc/python/grpc_asyncio.html). During the process of prototyping and testing grpcio-aio and trying to debug and profile, we found that no data was being sent to New Relic APM. We were able to see the container and see it's CPU/Memory usage and such, but no info regarding requests was being captured at all.

This is obviously a huge problem for us, since we're heavily integrated into New Relic at the moment and moving to grpcio-aoi is something we definitely want to move toward as not doing so means, we can't start migrating customers from the legacy enviroment to our new Micro-services environment, so not being able to use grpcio-aio with New Relic is huge road block for us and something we need to resolve ASAP.

Feature Description

The same support we have for gRPC to be replicated Async gRPC

Describe Alternatives

N/A

Additional context

I have logged this via New Relic support too, feature request: PYTHON-I-151. They said it would be beneficial to post the request here too.

Priority

Blocker

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

synackSA commented 2 years ago

I mean, it would still be nice it it was supported...

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

GabrielCappelli commented 1 year ago

I've also migrated from sync gRPC to async gRPC and instrumentation no longer works 😞

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

MrBeeMovie commented 8 months ago

Is anyone going to look at this issue?

michal-th commented 1 week ago

Is there any update on this?

workato-integration[bot] commented 1 week ago

https://new-relic.atlassian.net/browse/NR-285374