Artifact creation and validation - Githubissues

newrelic / newrelic-quickstarts

New Relic One quickstarts help accelerate your New Relic journey by providing immediate value for your specific use cases.

https://newrelic.com/instant-observability/

Apache License 2.0

109 stars 298 forks source link

Artifact creation and validation #2540

Closed d3caf closed 1 week ago

d3caf commented 2 weeks ago

This is based on #2538 and adds a script to create the release artifact and validate it.

Todo

[x] Validate artifact with JSON schema
[x] Verify that artifact is properly created
[x] ~Save artifact to filesystem (or in a way that can be published easily by the next step in the process)~
[x] ~Set up GH action to run script~

d3caf commented 1 week ago

Status

I have the validations running properly and outputting the errors to the console. Next steps would be:

[x] Fix existing quickstarts that are failing validations (they're actually invalid, we just never validated them super closely)
[x] Code cleanup/refactor
[x] Evaluate whether we want to use json-schema-to-ts to generate the TS interface for the artifact (may be unnecessary)
[x] ~Save the artifact in a way that GH actions can use it~ (will be handled in future tickets)
[x] ~Set up GH action~ (will be handled in future tickets)

CLAassistant commented 1 week ago

All committers have signed the CLA.