search

newrelic / newrelic-ruby-agent

New Relic RPM Ruby Agent
https://docs.newrelic.com/docs/apm/agents/ruby-agent/getting-started/introduction-new-relic-ruby/
Apache License 2.0
1.2k stars 599 forks source link

CI: Update JRuby to v9.4.0.0 #1661

Closed fallwith closed 1 year ago

fallwith commented 1 year ago

We should update the JRuby version we test with to v9.4.0.0 (from v9.3.9.0).

JRuby v9.4.0.0 is designed with Ruby v3.1 and Rails v7.0 compatibility in mind. The RUBY_VERSION constant itself reports "3.1.0".

This is a significant upgrade that is expected to have more issues than might normally arise from a minor version upgrade. As with CRuby 3.1, unsafe YAML parsing is no longer permitted (this will impact all older Rails version testing). Bundler v2 seems to be required, impacting tests that insist on Bundler v1. The new RUBY_VERSION constant value will push code that was previously expected to only be executed by CRuby v3+ into JRuby's purview and expose some previously unearthed compatibility issues.

Given that our agent goes lower level than the average Ruby app and prides itself on extreme compatibility and resilience with a tremendous variety of Ruby versions and gem versions, testing with JRuby remains valuable for us. In particular, JRuby famously drives Ruby specifications and documentation forward and it remains an important litmus test for compatibility.

workato-integration[bot] commented 1 year ago

https://issues.newrelic.com/browse/NEWRELIC-5618

fallwith commented 1 year ago

Resolved with #1651

NOTE that new JRuby issues #1662, #1663, #1664, and #1665 - all of which are assumed at this point to only impact our CI system and not production customer usage of the agent - were created for future investigation.