newrelic / newrelic-ruby-agent

New Relic RPM Ruby Agent
https://docs.newrelic.com/docs/apm/agents/ruby-agent/getting-started/introduction-new-relic-ruby/
Apache License 2.0
1.2k stars 598 forks source link

Log Decoration Support for Semantic Logger #2341

Open chris-judd opened 11 months ago

chris-judd commented 11 months ago

Is your feature request related to a problem? Please describe.

Currently, logs coming from the SemanticLogger are not decorated for traceId. This breaks the Logs In Context feature for Ruby APM Services when browsing the Distributed Tracing curated views.

Feature Description

Update NR Ruby Agent to support SymantecLogger's implementation of log forwarding so that log decoration is successful.

Describe Alternatives

None

Additional context

SemanticLogger added support for forwarding logs using the New Relic ruby agent, but this was not implemented by NR. It appears that the way they did this is to record their logs directly to the agents aggregator, which would bypass the part of the agent that would be decorating any logs.

Priority

Must Have

kford-newrelic commented 10 months ago

Blocked by #2358 ? Not sure we can tackle this one for the current jan-mar qtr...

workato-integration[bot] commented 10 months ago

https://new-relic.atlassian.net/browse/NR-214470

workato-integration[bot] commented 10 months ago

The problem is a duplicate of an existing issue.

kford-newrelic commented 10 months ago

Inadvertently closed. Re-opening and putting on backlog for future consideration.