newrelic / newrelic-ruby-agent

New Relic RPM Ruby Agent
https://docs.newrelic.com/docs/apm/agents/ruby-agent/getting-started/introduction-new-relic-ruby/
Apache License 2.0
1.2k stars 596 forks source link

CI: Upgrade to a newer version of Node for our SimpleCov action #2597

Closed kaylareopelle closed 1 month ago

kaylareopelle commented 4 months ago

Node 16 is deprecated. Similar to #2584, we should update our SimpleCov action to, at a minimum, use Node 20, but preferably, use Node 22 or the latest version whenever this ticket is worked on.

Screenshot 2024-04-24 at 12 11 16 PM

Currently, we have a forked copy of this action living in the .github/actions directory. There may be multiple changes in our fork from the original, but one of the features is the addition of branch coverage percentages in the comments added to PRs after test runs.

We could also consider, as part of this ticket, contributing our changes to the original action or pushing up a fork of our action with our added functionality.

workato-integration[bot] commented 4 months ago

https://new-relic.atlassian.net/browse/NR-262200

prateeksen commented 4 months ago

@kaylareopelle Not only simplecov-report there are other github actions as well for which similar warnings are visible. Few are in this workflow

kaylareopelle commented 4 months ago

Thank you, @prateeksen! We've created issues for all the outdated actions. You can find them under https://github.com/newrelic/newrelic-ruby-agent/labels/ci%20node%20updates

kaylareopelle commented 4 months ago

PR for similar work in csec-ruby-agent: https://github.com/newrelic/csec-ruby-agent/pull/78/files

prateeksen commented 4 months ago

The above mentioned PR has incomplete changes. Please use this as well. https://github.com/newrelic/csec-ruby-agent/pull/79/files

prateeksen commented 4 months ago

Simplecov-report-action is now archived, today. They are suggesting to use: octocov

kaylareopelle commented 4 months ago

Thanks for these updates, @prateeksen!

hannahramadan commented 1 month ago

Simplecov was updated in a previous PR. https://github.com/newrelic/newrelic-ruby-agent/pull/2787/files#diff-c4f51a333bc84a9c03d3cf76e88f242bcda512b4f4d4f93fe566dc3e8a57be31L24