search

newrelic / newrelic-ruby-agent

New Relic RPM Ruby Agent
https://docs.newrelic.com/docs/apm/agents/ruby-agent/getting-started/introduction-new-relic-ruby/
Apache License 2.0
1.2k stars 598 forks source link

Unit tests coverage report artifacts are not stored in github actions #2786

Closed prateeksen closed 2 weeks ago

prateeksen commented 1 month ago

Unit tests coverage report artifacts are not stored in github actions. My prime guess is that this issue could has been arrived while updating the artifact upload plugin in this commit as plugin has changed the regex matching mechanism. Earlier I had also faced a similar issue while upgrading the upload artifact in csec-ruby-agent and here are the PR links for the solution implemented. #78 & #79

workato-integration[bot] commented 1 month ago

https://new-relic.atlassian.net/browse/NR-296284

kaylareopelle commented 1 month ago

Thanks for raising this, @prateeksen! I'm going to remove the bug label from this issue because it's a bug related to the CI and not the agent itself, and add technical debt instead.

hannahramadan commented 3 weeks ago

Hi @prateeksen! I'm looking into this and am having trouble spotting the issue. On the Ruby agent side, I am seeing results uploaded for Infinite Tracing, Unit Tests, and Multiverse (we have a few more testing groups than csec). Here is an example run. Because we have these three separate groups, we then stitch the results together and upload a final artifact named coverage-report-combined, which is at the top of artifacts list in the example.

Good note on the upgrade from v3 to v4 of actions/upload-artifact! We also recently upgraded a few of our CI actions (PR) and had to make the same changes of creating dynamic/unique artifact names.

prateeksen commented 3 weeks ago

Hi @hannahramadan Thanks for the update. I again checked the link you provided and I see that artifacts are saved in combined report, last time I checked I didn't found the a artifacts in combined report and hence reported this issue, Maybe I have seen some incomplete build run. If we have the artifacts saved and seeing expected behaviour you can close the issue. Thanks.