newrelic / newrelic-ruby-agent

New Relic RPM Ruby Agent
https://docs.newrelic.com/docs/apm/agents/ruby-agent/getting-started/introduction-new-relic-ruby/
Apache License 2.0
1.2k stars 598 forks source link

Config: apply type coercion, at least for integer based values #2935

Open fallwith opened 3 weeks ago

fallwith commented 3 weeks ago

We have some configuration parameter value type coercion logic parked in the lab branch which is a) passing all CI tests, b) received dev approval, and c) passed csec tests for known integer handling issues.

Our CI suites involve lots and lots of iterations that completely flush and entirely reinitialize all agent configuration and layering in type coercion does have a performance impact that is easily seen in a CI context. Before merging the type coercion logic in, we'd like to be absolutely sure that the performance hit is expected to be slight outside of a CI context.

As a fallback plan, we should at least incorporate integer focused coercion for the csec agent's benefit.

workato-integration[bot] commented 3 weeks ago

https://new-relic.atlassian.net/browse/NR-336421