newrelic / newrelic-ruby-agent

New Relic RPM Ruby Agent
https://docs.newrelic.com/docs/apm/agents/ruby-agent/getting-started/introduction-new-relic-ruby/
Apache License 2.0
1.2k stars 598 forks source link

aws-sdk-lambda fix #2939

Closed fallwith closed 2 weeks ago

fallwith commented 2 weeks ago

commit 0a1527d8012cfb34c3950d34180d0974b51ab9ed sought to improve error handling, but incorrectly misused an ensure block to attempt to always return the raw client response.

this faulty logic has been fixed. internal agent response handling errors are logged as desired, not re-raised to the user's app, and the user's app is guaranteed to always get the raw original response.

github-actions[bot] commented 2 weeks ago

SimpleCov Report

Coverage Threshold
Line 93.85% 93%
Branch 69.73% 50%