search

newrelic / newrelic-ruby-agent

New Relic RPM Ruby Agent
https://docs.newrelic.com/docs/apm/agents/ruby-agent/getting-started/introduction-new-relic-ruby/
Apache License 2.0
1.2k stars 598 forks source link

View Component instrumentation: use `source_location` or `identifier` #2956

Closed hannahramadan closed 3 days ago

hannahramadan commented 6 days ago

View Component has formally exposed .identifier as a part of their public API (PR). We should make use of this API for building metric names when it is available. To ensure instrumentation support for all versions, we will continue to check for .source_location and then .identifier. The use of .identifier generates log warns in some View Component versions, so we want to first check for .source_location

Closes #2950

github-actions[bot] commented 6 days ago

SimpleCov Report

Coverage Threshold
Line 93.87% 93%
Branch 69.77% 50%