Fix modular build issues for telemetry-all

newrelic / newrelic-telemetry-sdk-java

Java library for sending telemetry data to New Relic

Apache License 2.0

41 stars 37 forks source link

Fix modular build issues for telemetry-all #227

Closed ysb33r closed 4 years ago

ysb33r commented 4 years ago

Renamed directory telemetry_core -> telemetry-core
Cleaned up subprojects fox consistency
Keep all versions in gradle.properties so that they are consitent across the project
Make telemetry-all a fully modular build.

// cc @kittylyst

ysb33r commented 4 years ago

@breedx-nr If we need to keep the gson shading, we'll need to change the build as to build a modular telemetry-all without the shading and build telemetry-core with shading. it will make the build more complex of course, but it is achievable.

kittylyst commented 4 years ago

I am not sure that we can remove the gson shading, because of #149 and #72 and some related fallout. This was user-submitted, and solves a very specific case where the user needs a different version of gson than telemetry-core needs. As such, we decided to shade it into the jar.

OK. So instead we need to ship a non-modular set of split jars with shading and a single, modular jar without shading. The latter can possibly break any customers because no-one's using it yet!

ysb33r commented 4 years ago

I'm closing this and creating a new PR