search

newrelic / newrelic-telemetry-sdk-python

A python library to send data to New Relic!
https://newrelic.github.io/newrelic-telemetry-sdk-python/
Apache License 2.0
35 stars 27 forks source link

Add timeout #47

Closed julcsii closed 2 years ago

julcsii commented 2 years ago

I often face the problem when sending a New Relic event from a Databricks notebook that the request does not time out.

I would like to add the timeout parameter so it can fail faster and I can implement retries in my code.

Please let me know if there's something missing in my PR and any feedback is welcome!

Thank you!

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

umaannamalai commented 2 years ago

Hi @julcsii! Thank you for submitting this PR. These changes look good πŸ‘πŸ½ We will work on getting these tests passing and merge this shortly.

julcsii commented 2 years ago

Hi @julcsii! Thank you for submitting this PR. These changes look good πŸ‘πŸ½ We will work on getting these tests passing and merge this shortly.

Thank you!

julcsii commented 2 years ago

Hi, we would like to have this PR merged as it's blocking us from using New Relic in our systems. Could you please have a look at the tests and merge?

codecov-commenter commented 2 years ago

Codecov Report

Merging #47 (818a60b) into main (f089f53) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          376       376           
  Branches        60        60           
=========================================
  Hits           376       376
Impacted Files Coverage Ξ”
src/newrelic_telemetry_sdk/client.py 100.00% <100.00%> (ΓΈ)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

TimPansino commented 2 years ago

We'll queue this up to release on Monday, thanks for the contribution πŸ‘