search

newrelic / newrelic-telemetry-sdk-python

A python library to send data to New Relic!
https://newrelic.github.io/newrelic-telemetry-sdk-python/
Apache License 2.0
34 stars 27 forks source link

urllib3 v2 support #72

Closed pray closed 1 week ago

pray commented 2 weeks ago

This PR adds support for urllib3 v2.x, following urllib3 1.x-2.x migration guide.

Projects have been adopting urllib3 v2, and in my case it's Airflow 2.x. This requires removing support for Python 2.

CLAassistant commented 2 weeks ago

CLA assistant check
All committers have signed the CLA.

TimPansino commented 1 week ago

I'll have to check and see if I have permission to remove Python 2.7 support for this project. Otherwise I'm happy to accept this PR.

There seems to be an issue with Urllib3 v2 on windows, looks like something related to the proxy settings. If you have a chance to see what that's about you can fix it in this PR, or I'll circle back and get it myself later when I have permission to move this forward.

thesuperzapper commented 1 week ago

@pray thanks for this, it's really important that newrelic-telemetry-sdk is supported in airflow, which currently uses urllib3==2.2.2 (as of Airflow 2.10.1).

Although I don't fully understand why we can't support both urllib3 version 1 and 2 like most other projects, they are largely compatible (which will allow both 2.7 and 3.6+).

TimPansino commented 1 week ago

Redirecting this to a dev branch so I can figure out the windows issue separately, and fix up the CI.