search

newrelic / node-native-metrics

Optional native module for collecting low-level Node & V8 metrics
Apache License 2.0
63 stars 41 forks source link

feat!: Removed support for Node.js 16 (#273) #274

Closed bizob2828 closed 3 months ago

bizob2828 commented 3 months ago

Description

Please provide a brief description of the changes introduced in this pull request. What problem does it solve? What is the context of this change?

How to Test

Please describe how you have tested these changes. Have you run the code against an example application? What steps did you take to ensure that the changes are working correctly?

Related Issues

Please include any related issues or pull requests in this section, using the format Closes #<issue number> or Fixes #<issue number> if applicable.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.59%. Comparing base (de17116) to head (3b10b04).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #274 +/- ## ========================================== - Coverage 97.81% 97.59% -0.23% ========================================== Files 1 1 Lines 183 166 -17 ========================================== - Hits 179 162 -17 Misses 4 4 ``` | [Flag](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | Coverage Δ | | |---|---|---| | [integration-tests-16-ubuntu-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [integration-tests-16-windows-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [integration-tests-16-windows-latest-x86](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [integration-tests-18-ubuntu-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `88.55% <100.00%> (+4.40%)` | :arrow_up: | | [integration-tests-18-windows-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `88.55% <100.00%> (+4.40%)` | :arrow_up: | | [integration-tests-18-windows-latest-x86](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `88.55% <100.00%> (+4.40%)` | :arrow_up: | | [integration-tests-20-ubuntu-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `88.55% <100.00%> (+4.40%)` | :arrow_up: | | [integration-tests-20-windows-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `88.55% <100.00%> (+4.40%)` | :arrow_up: | | [integration-tests-20-windows-latest-x86](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `88.55% <100.00%> (+4.40%)` | :arrow_up: | | [integration-tests-22-ubuntu-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `88.55% <100.00%> (+4.40%)` | :arrow_up: | | [integration-tests-22-windows-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `88.55% <100.00%> (+4.40%)` | :arrow_up: | | [integration-tests-22-windows-latest-x86](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `88.55% <100.00%> (+4.40%)` | :arrow_up: | | [unit-tests-16-ubuntu-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [unit-tests-16-windows-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [unit-tests-16-windows-latest-x86](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [unit-tests-18-ubuntu-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `97.59% <100.00%> (+5.24%)` | :arrow_up: | | [unit-tests-18-windows-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `97.59% <100.00%> (+5.24%)` | :arrow_up: | | [unit-tests-18-windows-latest-x86](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `97.59% <100.00%> (+5.24%)` | :arrow_up: | | [unit-tests-20-ubuntu-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `97.59% <100.00%> (+5.24%)` | :arrow_up: | | [unit-tests-20-windows-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `97.59% <100.00%> (+5.24%)` | :arrow_up: | | [unit-tests-20-windows-latest-x86](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `97.59% <100.00%> (+5.24%)` | :arrow_up: | | [unit-tests-22-ubuntu-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `97.59% <100.00%> (+5.24%)` | :arrow_up: | | [unit-tests-22-windows-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `97.59% <100.00%> (+5.24%)` | :arrow_up: | | [unit-tests-22-windows-latest-x86](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `97.59% <100.00%> (+5.24%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.