newrelic / node-newrelic

New Relic Node.js agent code base. Developers are welcome to create pull requests here, please see our contributing guidelines. For New Relic technical support, please go to http://support.newrelic.com.
Apache License 2.0
970 stars 399 forks source link

No SocketIO Prisma database queries being captured #1666

Open KevinBusch opened 1 year ago

KevinBusch commented 1 year ago

No SocketIO Prisma database queries being captured

Description

We are using the most update-to-date New Relic agent and it is capturing database queries now from Prisma (THANK YOU!) but only for queries executed from code within our HTTP endpoints. Any queries executed from code sourced from our persistent web socket connections do not appear to be tracked. NOTE: We are running on top of FeathersJS / Prisma. Why?

See original request here for more information. https://forum.newrelic.com/s/hubtopic/aAX8W0000008f99WAA/new-relic-nodejs-agent-now-instruments-prisma?t=1686310540023

Expected Behavior

All Prisma database queries should be captured from Prisma regardless of where they're sourced from (HTTP endpoint or web socket connection)

Troubleshooting or NR Diag results

Nothing to output (since NR isn't capturing anything 😉 )

Steps to Reproduce

Install FeathersJS / Prisma alongside NR agent and set up two connections (HTTPS endpoint vs Socket IO connection). Execute a query in both. Socket IO connection queries don't get captured.

Your Environment

    "@feathersjs/authentication": "^4.5.14",
    "@feathersjs/authentication-client": "^4.5.14",
    "@feathersjs/authentication-local": "^4.5.14",
    "@feathersjs/configuration": "^4.5.14",
    "@feathersjs/errors": "^4.5.14",
    "@feathersjs/express": "^4.5.14",
    "@feathersjs/feathers": "^4.5.14",
    "@feathersjs/rest-client": "^4.5.14",
    "@feathersjs/socketio": "^4.5.14",
    "@feathersjs/socketio-client": "^4.5.14",
    "@feathersjs/transport-commons": "^4.5.14",
    "feathers-prisma": "^0.3.2",
    "prisma": "^4.7.1",
    "@prisma/client": "^4.7.1",

Additional context

Can't think of anything

workato-integration[bot] commented 1 year ago

https://issues.newrelic.com/browse/NEWRELIC-9275

jmartin4563 commented 1 year ago

Hi @KevinBusch, we currently don't support SocketIO instrumentation, so I'll be moving this ticket to a feature request to get prioritized.