newrelic / node-newrelic

New Relic Node.js agent code base. Developers are welcome to create pull requests here, please see our contributing guidelines. For New Relic technical support, please go to http://support.newrelic.com.
Apache License 2.0
966 stars 395 forks source link

Add new span attributes to SQS calls to facilitate entity relationships #2377

Closed bizob2828 closed 1 month ago

bizob2828 commented 1 month ago

Description

We need to add new span attributes so the cloud monitoring team can link SQS calls from Node.js app to AWS SQS:

Linking between APM and SQS entities is done using the following span attributes:

cloud.region, cloud.account.id, and messaging.destination.name can be derived from the queue URL. The queue URL follow the format:

https://sqs.{region}.amazonaws.com/{account.id}/{queue.name}.

Additional context

I don't think these should go into the common attributes here but instead add an after hook to parse the QueueUrl and add the relevant span attributes described above.

workato-integration[bot] commented 1 month ago

https://new-relic.atlassian.net/browse/NR-293325