newrelic / node-newrelic

New Relic Node.js agent code base. Developers are welcome to create pull requests here, please see our contributing guidelines. For New Relic technical support, please go to http://support.newrelic.com.
Apache License 2.0
971 stars 399 forks source link

chore: Updated q, superagent, and when tests to node:test #2773

Closed jsumners-nr closed 2 days ago

jsumners-nr commented 2 days ago

This PR resolves #2734.

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.21%. Comparing base (40aea36) to head (f503546). Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2773 +/- ## ========================================== - Coverage 97.25% 97.21% -0.05% ========================================== Files 294 294 Lines 46233 46315 +82 ========================================== + Hits 44965 45025 +60 - Misses 1268 1290 +22 ``` | [Flag](https://app.codecov.io/gh/newrelic/node-newrelic/pull/2773/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | Coverage Δ | | |---|---|---| | [integration-tests-cjs-18.x](https://app.codecov.io/gh/newrelic/node-newrelic/pull/2773/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `74.28% <ø> (+<0.01%)` | :arrow_up: | | [integration-tests-cjs-20.x](https://app.codecov.io/gh/newrelic/node-newrelic/pull/2773/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `74.29% <ø> (-0.01%)` | :arrow_down: | | [integration-tests-cjs-22.x](https://app.codecov.io/gh/newrelic/node-newrelic/pull/2773/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `74.32% <ø> (-0.02%)` | :arrow_down: | | [integration-tests-esm-18.x](https://app.codecov.io/gh/newrelic/node-newrelic/pull/2773/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `49.97% <ø> (+0.04%)` | :arrow_up: | | [integration-tests-esm-20.x](https://app.codecov.io/gh/newrelic/node-newrelic/pull/2773/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `49.98% <ø> (+0.04%)` | :arrow_up: | | [integration-tests-esm-22.x](https://app.codecov.io/gh/newrelic/node-newrelic/pull/2773/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `50.00% <ø> (+0.04%)` | :arrow_up: | | [unit-tests-18.x](https://app.codecov.io/gh/newrelic/node-newrelic/pull/2773/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `88.98% <ø> (+0.02%)` | :arrow_up: | | [unit-tests-20.x](https://app.codecov.io/gh/newrelic/node-newrelic/pull/2773/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `88.98% <ø> (+0.02%)` | :arrow_up: | | [unit-tests-22.x](https://app.codecov.io/gh/newrelic/node-newrelic/pull/2773/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `88.99% <ø> (+0.02%)` | :arrow_up: | | [versioned-tests-18.x](https://app.codecov.io/gh/newrelic/node-newrelic/pull/2773/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `78.99% <ø> (-0.18%)` | :arrow_down: | | [versioned-tests-20.x](https://app.codecov.io/gh/newrelic/node-newrelic/pull/2773/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `78.99% <ø> (-0.18%)` | :arrow_down: | | [versioned-tests-22.x](https://app.codecov.io/gh/newrelic/node-newrelic/pull/2773/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `79.00% <ø> (-0.18%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

jsumners-nr commented 2 days ago

LGTM, thanks for cleaning up the when tests

You're welcome. Really, I just couldn't even do the conversion without doing it 😭