search

newrelic / node-newrelic

New Relic Node.js agent code base. Developers are welcome to create pull requests here, please see our contributing guidelines. For New Relic technical support, please go to http://support.newrelic.com.
Apache License 2.0
971 stars 399 forks source link

RangeError: Maximum call stack size exceeded #50

Closed sschepens closed 11 years ago

sschepens commented 11 years ago

Since last update to the module my app crashes with: (node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit. Trace at IncomingMessage.EventEmitter.addListener (events.js:160:15) at IncomingMessage. (node_modules/newrelic/node_modules/continuation-local-storage/context.js:94:25) at IncomingMessage. (node_modules/newrelic/node_modules/continuation-local-storage/context.js:94:25) at IncomingMessage. (node_modules/newrelic/node_modules/continuation-local-storage/context.js:94:25) at IncomingMessage. (node_modules/newrelic/node_modules/continuation-local-storage/context.js:94:25) at IncomingMessage. (node_modules/newrelic/node_modules/continuation-local-storage/context.js:94:25) at IncomingMessage. (node_modules/newrelic/node_modules/continuation-local-storage/context.js:94:25) at IncomingMessage. (node_modules/newrelic/node_modules/continuation-local-storage/context.js:94:25) at IncomingMessage. (node_modules/newrelic/node_modules/continuation-local-storage/context.js:94:25) at IncomingMessage. (node_modules/newrelic/node_modules/continuation-local-storage/context.js:94:25)

node_modules/newrelic/node_modules/continuation-local-storage/context.js:0 (function (exports, require, module, filename, dirname) { 'use strict'; ^ RangeError: Maximum call stack size exceeded

othiym23 commented 11 years ago

Thanks for the report!

  1. What was the last version of the module you were running?
  2. Can you either paste in your package.json in a comment here or send it to me at forrest@newrelic.com?

We haven't run into this issue before, and I need some help to isolate it. Thanks!

othiym23 commented 11 years ago

Also, what version of Node are you running?

sschepens commented 11 years ago

I was using 0.11.2 before switching to 0.11.4. The app runs with node 0.10.13 and has the following package.json: { "name": "name", "main": "./app.js", "version": "0.0.1", "engine": ">0.10.0", "dependencies": { "express": "3.4.x", "request": "2.27.x", "winston": "0.7.1", "express-winston": "0.2.x", "newrelic": ">0.9.20", "mongodb": "1.3.x" }, "devDependencies": { "mocha": "1.12.x", "should": "1.2.x", "nock": "0.22.x" } }

sschepens commented 11 years ago

By the way, if its any use, the app uses node's cluster module to spawn 3 workers

othiym23 commented 11 years ago

Thanks for the details! I'll let you know as soon as I have a candidate fix for this.

pjr0009 commented 11 years ago

+1 for this, here is my json.package. my app also uses cluster and spawns 4 workers

"dependencies": { "express": ">= 3.1.0", "ejs": ">= 0.8.4", "passport": "latest", "passport-local": "latest", "bcrypt": "latest", "newrelic": "latest", "supervisor": "latest", "angularytics": "latest", "underscore": "latest", "redis": "latest", "util": "latest", "connect-redis": "latest", "request": "latest", "nodetime": "latest" }, "engines": { "node": "0.10.17" },

othiym23 commented 11 years ago

@pjr0009 @sschepens I'm working on this now. If either you have the time or inclination to help me find a reduced test case, that would be very useful. Thanks!

pjr0009 commented 11 years ago

Wow, thanks for the immediate response. I'm currently dealing with issues concerning my application, but if i have a chance i'll look into it as well. thanks!

@pjr0009https://github.com/pjr0009 @sschepenshttps://github.com/sschepens I'm working on this now. If either you have the time or inclination to help me find a reduced test case, that would be very useful. Thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/newrelic/node-newrelic/issues/50#issuecomment-25567982.

nlaplante commented 11 years ago

Watching this as well, got this error since 0.11.4

othiym23 commented 11 years ago

Update: I'm still trying to reproduce this issue, but have made a few other changes to the library the module uses that's causing the problem. Could those of you watching this do two things for me?

  1. gist or paste me the app.use / app.configure bits from your applications? I assume you're all using Express (if you're not, let me know).
  2. Try the following:
cd <root directory of your application>
cd node_modules/newrelic
npm install continuation-local-storage@2.3.2

and then verify that the crash still happens? Thanks!

nlaplante commented 11 years ago

Try the following: cd cd node_modules/newrelic npm install continuation-local-storage@2.3.2 and then verify that the crash still happens? Thanks!

I tried reenabling newrelic in my app (it has an on/off switch I've setup) and curiously I had zero issue, without updating to the version you specify. I tried running as a standalone node app, and then with forever start. In both cases, I don't get any error and it reports successfuly to New Relic.

This is very strange. It would fail 100% of the time earlier today and now it works...

nlaplante commented 11 years ago

Wait. Igonre last post. Errored out. Trying to update to new version.

nlaplante commented 11 years ago

Got same error after updating to continuation-local-storage@2.3.2.

nlaplante commented 11 years ago

Here's my app.js: https://github.com/nlaplante/profolio/blob/develop/app.js

othiym23 commented 11 years ago

Thanks to @nlaplante making his application available, I think I've nailed this bug down. Could one or more of you try the following and tell me if it fixes the problem?

cd <root directory of your application>
cd node_modules/newrelic
npm install continuation-local-storage@2.3.3

(note that the version has increased to 2.3.3 from 2.3.2.

Once one of you has confirmed that your app is no longer crashing, I'll publish a new version of the New Relic module with this fix. Thanks for your help!

nlaplante commented 11 years ago

Hi @othiym23 , just tried with 2.3.3. As soon as I make a POST request to /api/auth/login, I get the stack trace:

(node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit.
Trace
at IncomingMessage.EventEmitter.addListener (events.js:160:15)
at IncomingMessage.captured [as on] (/home/nlaplante/dev.nlaplante.com/node_modules/newrelic/node_modules/continuation-local-storage/context.js:99:19)
at listen (/home/nlaplante/dev.nlaplante.com/node_modules/express/node_modules/connect/lib/middleware/limit.js:69:11)
at /home/nlaplante/dev.nlaplante.com/node_modules/newrelic/node_modules/continuation-local-storage/node_modules/async-listener/glue.js:61:27
at process._tickDomainCallback (node.js:459:13)
at process.<anonymous> (/home/nlaplante/dev.nlaplante.com/node_modules/newrelic/node_modules/continuation-local-storage/node_modules/async-listener/index.js:18:15)
Killed
nlaplante commented 11 years ago 
grep version node_modules/newrelic/node_modules/continuation-local-storage/package.json
  "version": "2.3.3",
othiym23 commented 11 years ago

Damn. Thanks! I'll keep pushing on this.

nlaplante commented 11 years ago

Stellar response time! If you need anything else let me know.

othiym23 commented 11 years ago

@nlaplante I've downloaded a copy of profolio and am running it locally, but I can't seem to reproduce this bug. What version of Node are you running, what OS are you running on, and is there anything special about how you have your instance of profolio configured? (Neat-looking app, by the way.)

nlaplante commented 11 years ago

Ok thanks. This will be my 2nd generation photoblog I'm working on :) Will replace what's on http://www.nlaplante.com/.

Back on topic, just enabled new relic locally on my dev machine, upgraded to continuation-local-storage@2.3.3 and everything works fine UNTIL you try to login.

Try it. Username 'admin' and password 'admin' by default.

pjr0009 commented 11 years ago

yes this is exactly the problem i was having, seemed like on any POST requests it would produce this error. On Oct 3, 2013, at 8:46 AM, Forrest L Norvell notifications@github.com<mailto:notifications@github.com> wrote:

@nlaplantehttps://github.com/nlaplante I've downloaded a copy of profolio and am running it locally, but I can't seem to reproduce this bug. What version of Node are you running, what OS are you running on, and is there anything special about how you have your instance of profolio configured? (Neat-looking app, by the way.)

— Reply to this email directly or view it on GitHubhttps://github.com/newrelic/node-newrelic/issues/50#issuecomment-25632099.

othiym23 commented 11 years ago

@nlaplante I've hooked up an S3 bucket (and edited services/storage.js to point at my bucket), I've got MongoDB running on my laptop, and I've reinstalled node_modules. This is what I get when I run it:

% nave use 0.10.4 node app.js
######################################################################## 100.0%
installed from binary
using 0.10.4
2013-10-03T09:26:10 INFO  profolio     starting up version 0.0.1
2013-10-03T09:26:10 DEBUG datasource   using following connection string: mongodb://localhost/profolio
2013-10-03T09:26:10 INFO  mailer       configuring SMTP transport
2013-10-03T09:26:11 INFO  profolio     HTTP server up on port 3000
2013-10-03T09:26:11 DEBUG odm          users ensureIndex {"username":1}
2013-10-03T09:26:11 DEBUG odm          users findOne {"username":"admin"}
2013-10-03T09:26:11 DEBUG odm          photos ensureIndex {"slug":1}
2013-10-03T09:26:11 DEBUG odm          photos ensureIndex {"title":1}
2013-10-03T09:26:11 DEBUG odm          photos ensureIndex {"filename":1}
2013-10-03T09:26:11 INFO  datasource   connected to MongoDB 2.4.6 server on localhost (Mac OS X 12.5.0)
2013-10-03T09:26:11 ERR   spamfilter   could not verify akismet key [Error: We were unable to parse your blog URI]
2013-10-03T09:26:21 INFO  http         GET / 200 110 ms
2013-10-03T09:26:22 DEBUG odm          photos find {}
2013-10-03T09:26:22 INFO  http         GET /api/photos 200 10 ms
2013-10-03T09:26:22 INFO  http         GET /views/home 200 21 ms
2013-10-03T09:26:28 INFO  http         GET /views/login 200 41 ms
2013-10-03T09:26:32 DEBUG odm          users findOne {"username":"admin"}
2013-10-03T09:26:32 INFO  http         POST /api/auth/login 200 82 ms
2013-10-03T09:26:32 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:26:32 DEBUG odm          photos find {}
2013-10-03T09:26:32 INFO  http         GET /api/photos 200 3 ms

(with no crash, to be clear)

What do you see that's different?

othiym23 commented 11 years ago

Could one of you remove newrelic_agent.log, edit newrelic.js to set the logging level to 'trace', and let everything run until the app crashes and then gzip or bzip2 newrelic_agent.log and email it to forrest@newrelic.com?

nlaplante commented 11 years ago

Are you using the develop branch? Develop branch has a working S3 storage engine (and I don't see it spitting log messages in your startup logs).

Checkout the develop branch, and use the dashboard settings to configure your storage engine after logging in.

On Thu, Oct 3, 2013 at 12:29 PM, Forrest L Norvell <notifications@github.com

wrote:

@nlaplante https://github.com/nlaplante I've hooked up an S3 bucket (and edited services/storage.js to point at my bucket), I've got MongoDB running on my laptop, and I've reinstalled node_modules. This is what I get when I run it:

% nave use 0.10.4 node app.js ######################################################################## 100.0% installed from binary using 0.10.4 2013-10-03T09:26:10 INFO profolio starting up version 0.0.1 2013-10-03T09:26:10 DEBUG datasource using following connection string: mongodb://localhost/profolio 2013-10-03T09:26:10 INFO mailer configuring SMTP transport 2013-10-03T09:26:11 INFO profolio HTTP server up on port 3000 2013-10-03T09:26:11 DEBUG odm users ensureIndex {"username":1} 2013-10-03T09:26:11 DEBUG odm users findOne {"username":"admin"} 2013-10-03T09:26:11 DEBUG odm photos ensureIndex {"slug":1} 2013-10-03T09:26:11 DEBUG odm photos ensureIndex {"title":1} 2013-10-03T09:26:11 DEBUG odm photos ensureIndex {"filename":1} 2013-10-03T09:26:11 INFO datasource connected to MongoDB 2.4.6 server on localhost (Mac OS X 12.5.0) 2013-10-03T09:26:11 ERR spamfilter could not verify akismet key [Error: We were unable to parse your blog URI] 2013-10-03T09:26:21 INFO http GET / 200 110 ms 2013-10-03T09:26:22 DEBUG odm photos find {} 2013-10-03T09:26:22 INFO http GET /api/photos 200 10 ms 2013-10-03T09:26:22 INFO http GET /views/home 200 21 ms 2013-10-03T09:26:28 INFO http GET /views/login 200 41 ms 2013-10-03T09:26:32 DEBUG odm users findOne {"username":"admin"} 2013-10-03T09:26:32 INFO http POST /api/auth/login 200 82 ms 2013-10-03T09:26:32 DEBUG odm users findOne {"_id":"524cebc9c63b235a87000002"} 2013-10-03T09:26:32 DEBUG odm photos find {} 2013-10-03T09:26:32 INFO http GET /api/photos 200 3 ms

(with no crash, to be clear)

What do you see that's different?

— Reply to this email directly or view it on GitHubhttps://github.com/newrelic/node-newrelic/issues/50#issuecomment-25635761 .

Sent from Gmail web

nlaplante commented 11 years ago

Just to be sure we're on the same codebase

On Thu, Oct 3, 2013 at 12:32 PM, Nicolas Laplante < nicolas.laplante@gmail.com> wrote:

Are you using the develop branch? Develop branch has a working S3 storage engine (and I don't see it spitting log messages in your startup logs).

Checkout the develop branch, and use the dashboard settings to configure your storage engine after logging in.

On Thu, Oct 3, 2013 at 12:29 PM, Forrest L Norvell < notifications@github.com> wrote:

@nlaplante https://github.com/nlaplante I've hooked up an S3 bucket (and edited services/storage.js to point at my bucket), I've got MongoDB running on my laptop, and I've reinstalled node_modules. This is what I get when I run it:

% nave use 0.10.4 node app.js ######################################################################## 100.0% installed from binary using 0.10.4 2013-10-03T09:26:10 INFO profolio starting up version 0.0.1 2013-10-03T09:26:10 DEBUG datasource using following connection string: mongodb://localhost/profolio 2013-10-03T09:26:10 INFO mailer configuring SMTP transport 2013-10-03T09:26:11 INFO profolio HTTP server up on port 3000 2013-10-03T09:26:11 DEBUG odm users ensureIndex {"username":1} 2013-10-03T09:26:11 DEBUG odm users findOne {"username":"admin"} 2013-10-03T09:26:11 DEBUG odm photos ensureIndex {"slug":1} 2013-10-03T09:26:11 DEBUG odm photos ensureIndex {"title":1} 2013-10-03T09:26:11 DEBUG odm photos ensureIndex {"filename":1} 2013-10-03T09:26:11 INFO datasource connected to MongoDB 2.4.6 server on localhost (Mac OS X 12.5.0) 2013-10-03T09:26:11 ERR spamfilter could not verify akismet key [Error: We were unable to parse your blog URI] 2013-10-03T09:26:21 INFO http GET / 200 110 ms 2013-10-03T09:26:22 DEBUG odm photos find {} 2013-10-03T09:26:22 INFO http GET /api/photos 200 10 ms 2013-10-03T09:26:22 INFO http GET /views/home 200 21 ms 2013-10-03T09:26:28 INFO http GET /views/login 200 41 ms 2013-10-03T09:26:32 DEBUG odm users findOne {"username":"admin"} 2013-10-03T09:26:32 INFO http POST /api/auth/login 200 82 ms 2013-10-03T09:26:32 DEBUG odm users findOne {"_id":"524cebc9c63b235a87000002"} 2013-10-03T09:26:32 DEBUG odm photos find {} 2013-10-03T09:26:32 INFO http GET /api/photos 200 3 ms

(with no crash, to be clear)

What do you see that's different?

— Reply to this email directly or view it on GitHubhttps://github.com/newrelic/node-newrelic/issues/50#issuecomment-25635761 .

Sent from Gmail web

Sent from Gmail web

othiym23 commented 11 years ago

@nlaplante On the develop branch:

% node app.js
2013-10-03T09:49:05 INFO  profolio     profolio 0.0.1 starting up
2013-10-03T09:49:05 DEBUG datasource   using following connection string: mongodb://localhost/profolio
2013-10-03T09:49:05 WARN  spamfilter   akismet configuration not set in social.json; spam filter is disabled
2013-10-03T09:49:05 INFO  storage      using Amazon S3 storage engine
2013-10-03T09:49:05 INFO  storage-s3   temporary thumbnail generation path: /tmp
2013-10-03T09:49:05 INFO  storage-s3   region: us-east-1
2013-10-03T09:49:05 INFO  storage-s3   bucket name: aaxz-testing
2013-10-03T09:49:05 INFO  storage-s3   URL path to bucket: http://aaxz-testing.s3.amazonaws.com/profolio/
2013-10-03T09:49:05 INFO  mailer       configuring SMTP transport
2013-10-03T09:49:06 DEBUG odm          users ensureIndex {"username":1}
2013-10-03T09:49:06 DEBUG odm          users findOne {"username":"admin"}
2013-10-03T09:49:06 DEBUG odm          photos ensureIndex {"slug":1}
2013-10-03T09:49:06 INFO  datasource   datasource connected and available
2013-10-03T09:49:06 DEBUG odm          photos ensureIndex {"title":1}
2013-10-03T09:49:06 INFO  session      persistent session store initialized
2013-10-03T09:49:06 INFO  http         HTTP service up and running on 0.0.0.0:3000 (745 ms)
2013-10-03T09:49:06 DEBUG odm          photos ensureIndex {"filename":1}
2013-10-03T09:49:20 INFO  http         GET / 200 112 ms
2013-10-03T09:49:21 INFO  http         GET /api/version 200 1 ms
2013-10-03T09:49:21 INFO  http         GET /api/auth/check 401 1 ms
2013-10-03T09:49:21 DEBUG odm          photos find {}
2013-10-03T09:49:21 INFO  http         GET /api/photos 200 5 ms
2013-10-03T09:49:21 INFO  http         GET /views/home 200 15 ms
2013-10-03T09:49:26 INFO  http         GET /views/login 200 27 ms
2013-10-03T09:49:31 DEBUG odm          users findOne {"username":"admin"}
2013-10-03T09:49:31 INFO  http         POST /api/auth/login 200 81 ms
2013-10-03T09:49:31 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:49:31 DEBUG odm          photos find {}
2013-10-03T09:49:31 INFO  http         GET /api/photos 200 3 ms
2013-10-03T09:49:35 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:49:35 INFO  http         GET /views/upload 200 54 ms
2013-10-03T09:49:54 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:49:54 INFO  upload       creating new upload manager
2013-10-03T09:49:54 INFO  upload       extracting EXIF metadata
2013-10-03T09:49:54 INFO  http         POST /api/photos/upload 200 144 ms
2013-10-03T09:50:10 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:10 DEBUG odm          photos findOne {"slug":"p"}
2013-10-03T09:50:10 INFO  http         GET /api/photo/p 404 4 ms
2013-10-03T09:50:11 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:11 DEBUG odm          photos findOne {"slug":"pe"}
2013-10-03T09:50:11 INFO  http         GET /api/photo/pe 404 3 ms
2013-10-03T09:50:11 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:11 DEBUG odm          photos findOne {"slug":"pen"}
2013-10-03T09:50:11 INFO  http         GET /api/photo/pen 404 2 ms
2013-10-03T09:50:11 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:11 DEBUG odm          photos findOne {"slug":"pens"}
2013-10-03T09:50:11 INFO  http         GET /api/photo/pens 404 2 ms
2013-10-03T09:50:11 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:11 DEBUG odm          photos findOne {"slug":"pensi"}
2013-10-03T09:50:11 INFO  http         GET /api/photo/pensi 404 3 ms
2013-10-03T09:50:11 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:11 DEBUG odm          photos findOne {"slug":"pensiv"}
2013-10-03T09:50:11 INFO  http         GET /api/photo/pensiv 404 2 ms
2013-10-03T09:50:11 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:11 DEBUG odm          photos findOne {"slug":"pensive"}
2013-10-03T09:50:11 INFO  http         GET /api/photo/pensive 404 2 ms
2013-10-03T09:50:12 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:12 DEBUG odm          photos findOne {"slug":"pensive-p"}
2013-10-03T09:50:12 INFO  http         GET /api/photo/pensive-p 404 2 ms
2013-10-03T09:50:12 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:12 DEBUG odm          photos findOne {"slug":"pensive-pa"}
2013-10-03T09:50:12 INFO  http         GET /api/photo/pensive-pa 404 2 ms
2013-10-03T09:50:12 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:12 DEBUG odm          photos findOne {"slug":"pensive-par"}
2013-10-03T09:50:12 INFO  http         GET /api/photo/pensive-par 404 2 ms
2013-10-03T09:50:12 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:12 DEBUG odm          photos findOne {"slug":"pensive-para"}
2013-10-03T09:50:12 INFO  http         GET /api/photo/pensive-para 404 3 ms
2013-10-03T09:50:12 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:12 DEBUG odm          photos findOne {"slug":"pensive-parak"}
2013-10-03T09:50:12 INFO  http         GET /api/photo/pensive-parak 404 2 ms
2013-10-03T09:50:12 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:12 DEBUG odm          photos findOne {"slug":"pensive-parake"}
2013-10-03T09:50:12 INFO  http         GET /api/photo/pensive-parake 404 2 ms
2013-10-03T09:50:13 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:13 DEBUG odm          photos findOne {"slug":"pensive-parakee"}
2013-10-03T09:50:13 INFO  http         GET /api/photo/pensive-parakee 404 2 ms
2013-10-03T09:50:13 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:13 DEBUG odm          photos findOne {"slug":"pensive-parakeet"}
2013-10-03T09:50:13 INFO  http         GET /api/photo/pensive-parakeet 404 2 ms
2013-10-03T09:50:33 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:33 INFO  upload       creating new upload manager
2013-10-03T09:50:33 INFO  upload       storing photo and thumbnails using configured storage engine
2013-10-03T09:50:33 INFO  thumbnails   generating thumbnail /tmp/pensive-parakeet-thumb-1900.jpg
2013-10-03T09:50:33 INFO  thumbnails   generating thumbnail /tmp/pensive-parakeet-thumb-900.jpg
2013-10-03T09:50:34 INFO  thumbnails   generating thumbnail /tmp/pensive-parakeet-thumb-400.jpg
2013-10-03T09:50:34 INFO  thumbnails   generating thumbnail /tmp/pensive-parakeet-thumb-100.jpg
2013-10-03T09:50:34 INFO  storage-s3   created new object 'aaxz-testing/profolio/thumbnails/pensive-parakeet-thumb-100.jpg'
2013-10-03T09:50:35 INFO  storage-s3   created new object 'aaxz-testing/profolio/thumbnails/pensive-parakeet-thumb-400.jpg'
2013-10-03T09:50:35 INFO  storage-s3   created new object 'aaxz-testing/profolio/thumbnails/pensive-parakeet-thumb-900.jpg'
2013-10-03T09:50:35 INFO  storage-s3   created new object 'aaxz-testing/profolio/thumbnails/pensive-parakeet-thumb-1900.jpg'
2013-10-03T09:50:35 INFO  storage-s3   all bucket operations complete
2013-10-03T09:50:35 INFO  upload       saving photo in database
2013-10-03T09:50:35 DEBUG odm          photos insert {"updatedAt":"2013-10-03T16:50:35.948Z","createdAt":"2013-10-03T16:50:35.948Z","description":"Dropbox sample image","filename":"pensive-parakeet.jpg","slug":"pensive-parakeet","title":"pensive parakeet","_id":"524da0597fcf6d02b3000004","keywords":[],"tags":{"flash":true,"width":1024,"height":768},"comments":[],"location":[null,null],"__v":0}
2013-10-03T09:50:35 INFO  http         POST /api/photos 200 2610 ms
2013-10-03T09:50:35 ERR   api:photos   error sending mail message [Error: Authentication required, invalid details provided]
2013-10-03T09:50:35 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:35 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:35 DEBUG odm          photos findOne {"slug":"pensive-parakeet"}
2013-10-03T09:50:36 INFO  http         GET /views/photo 200 44 ms
2013-10-03T09:50:36 INFO  http         GET /api/photo/pensive-parakeet 200 47 ms
2013-10-03T09:50:36 DEBUG odm          users findOne {"_id":"524cebc9c63b235a87000002"}
2013-10-03T09:50:36 INFO  http         GET /views/photo/metadata 200 6 ms

Is there anything special about how you run node?

nlaplante commented 11 years ago

Seems to be running fine. Did you enable newrelic in config/newrelic.json (enabled: true) ?

othiym23 commented 11 years ago

I did not! And when I did, crash city! It's been a long time since I've been so happy to see a crash! Awesome, I can now stop spamming this thread and see if I can figure out what's going on.

nlaplante commented 11 years ago

Good! Your support is much appreciated. Let me know if you need something

othiym23 commented 11 years ago

OK! I believe I have found and extirpated the actual issue! But to be sure:

cd <root directory of your application>
cd node_modules/newrelic
npm install continuation-local-storage@2.3.4

For those who are curious, the fix was landed in othiym23/node-continuation-local-storage@6caddcc3e061d1e3255b5b26393e9cb66d3bcab1 and the thing causing the problem was the limit middleware in Connect / Express. Once at least one of you confirms that this addresses the issue, I'll publish a new version of the Node agent with the fix.

nlaplante commented 11 years ago

Good. Will try this when I get back home later today. I'll keep you posted. Thanks for the efforts.

nlaplante commented 11 years ago

Ok tested and confirmed working with 2.3.4 on my dev server profolio install!

othiym23 commented 11 years ago

:tada:

Thanks so much for your help and the use of your sample app, Nicolas!

nlaplante commented 11 years ago

No problem! Anyway my app is open source :) As long as it gives me more chances to win the ultimate developer bundle, I'm ok with that :) haha. Thanks for your support.

othiym23 commented 11 years ago

This has been fixed in New Relic for Node.js 0.11.5. Thanks a ton for your help, everybody! Reopen if you run into situations the new version doesn't address!

pjr0009 commented 11 years ago

looks good, our music app https://www.upbeatapp.com/ is now using new relic again. thanks for saving us from nodetime!

On Oct 3, 2013, at 4:42 PM, Forrest L Norvell notifications@github.com<mailto:notifications@github.com> wrote:

0.11.5

nlaplante commented 11 years ago

looks good, our music app https://www.upbeatapp.com/ is now using new relic again. thanks for saving us from nodetime!

neat app!