Fastify transaction naming

[ISulimanov]

Description

According to https://github.com/newrelic/node-newrelic/pull/354 , if I understand correct we should have proper transactions name.

Expected Behavior

All transactions have proper name on Transactions page

Actual Begavior

All transactions have * instead of name

Steps to Reproduce

• Clone official demo Nest with Fastify from https://github.com/nestjs/nest/tree/master/sample/10-fastify
• Add newrelic according to official doc
• Run app and make few requests

Your Environment

Node.js version | v16.13.0 OS version | Windows 10.0.18362 NodeJs Agent | 8.5.2

[bizob2828]

@ISulimanov I cannot reproduce. I see transactions just fine.

The steps I took:

• Clone Fastify Nest Sample App
• npm install && npm install newrelic
• npm run build
• node -r newrelic dist/main.js

If you're still having trouble it might be best to go through our support team so they can ask for logs and help troubleshoot deeper.

[jungRoit]

I'm facing the same error @ISulimanov @bizob2828. What steps did you take to get it to work as intended?

[rwojsznis]

Samies, I'm using this approach regarding separating concerns - any chance it's related? 🤔

fastify 3.28.0, node v16.14.2, newrelic 8.14.1

edit: before even submitting comment I'm going to answer my own question - it's seems like that's the case. @jungRoit - given example linked above, if have something like:

const server = require('./app')({
  logger: {
    level: 'info',
    transport: {
      target: 'pino-pretty'
    }
  }
})

can you try wrapping server in newrelic as follows:

newrelic.instrumentLoadedModule(
  'fastify',
  server
);

and let me know if it helped? documentation mentions wrapping required fastify module, but I think when you separate concerns it doesn't work as expected - just a guess, I didn't looked into source code, nor I work with node on daily basis (and I'm grateful for that 😆 )