search

newrelic / node-test-utilities

Test helpers for Node.js instrumentation modules
Apache License 2.0
5 stars 15 forks source link

refactor: gate usage of loader in versioned tests by NR_LOADER environment variable #178

Closed jmartin4563 closed 10 months ago

jmartin4563 commented 11 months ago

Proposed Release Notes

Links

Details

Instead of completely removing the loader functionality for node 20, we're gating it off of the NR_LOADER environment variable, which was already part of the logic. This will make it easier on us when we re-add the ESM loader at a later date. Additionally bumped some deps to fix npm audit warnings.

codecov[bot] commented 11 months ago

Codecov Report

Merging #178 (6bb7a2b) into main (1107012) will decrease coverage by 0.05%. Report is 1 commits behind head on main. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   78.01%   77.97%   -0.05%     
==========================================
  Files          15       15              
  Lines        2429     2424       -5     
==========================================
- Hits         1895     1890       -5     
  Misses        534      534
Flag Coverage Δ
unit-tests-16.x 77.97% <100.00%> (-0.05%) :arrow_down:
unit-tests-18.x 77.97% <100.00%> (-0.05%) :arrow_down:
unit-tests-20.x 77.97% <100.00%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/versioned/runner.js 85.62% <100.00%> (ø)
lib/versioned/test.js 94.59% <100.00%> (-0.12%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more