bizob2828
commented
10 months ago We will have to wait to merge this until after we release 11.0.0 because the tests will not pass
Closed bizob2828 closed 10 months ago
bizob2828
commented
10 months ago We will have to wait to merge this until after we release 11.0.0 because the tests will not pass
codecov[bot]
commented
10 months ago Merging #179 (5bc3767) into main (3d0713e) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 77.97% 77.97%
=======================================
Files 15 15
Lines 2424 2424
=======================================
Hits 1890 1890
Misses 534 534 | Flag | Coverage Δ | |
|---|---|---|
| unit-tests-16.x | 77.97% <100.00%> (ø) |
|
| unit-tests-18.x | 77.97% <100.00%> (ø) |
|
| unit-tests-20.x | 77.97% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files Changed | Coverage Δ | |
|---|---|---|
| lib/agent.js | 98.44% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Proposed Release Notes
shimmer.registerHooksandshimmer.removeHooksto set up instrumentation and remove it.Links
This assumes the work in https://github.com/newrelic/node-newrelic/pull/1758 is merged and released.
Details
This change isn't necessary until after release of the agent because I kept those functions. Technically
shimmer.registerHooksshould now be called after bootstrapping instrumentation but it's ok for now.