search

newrelic / node-test-utilities

Test helpers for Node.js instrumentation modules
Apache License 2.0
5 stars 15 forks source link

chore: add missing data to lockfile #188

Closed jsumners-nr closed 5 months ago

jsumners-nr commented 5 months ago

Proposed Release Notes

Links

Details

bizob2828 commented 5 months ago

yea we should update to prevent this issue in the future. here's the workflow

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a26cc3d) 80.07% compared to head (c1af1b9) 80.07%.

:exclamation: Current head c1af1b9 differs from pull request most recent head ceb7018. Consider uploading reports for the commit ceb7018 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #188 +/- ## ======================================= Coverage 80.07% 80.07% ======================================= Files 23 23 Lines 3347 3347 ======================================= Hits 2680 2680 Misses 667 667 ``` | [Flag](https://app.codecov.io/gh/newrelic/node-test-utilities/pull/188/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | Coverage Δ | | |---|---|---| | [unit-tests-16.x](https://app.codecov.io/gh/newrelic/node-test-utilities/pull/188/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `80.07% <ø> (ø)` | | | [unit-tests-18.x](https://app.codecov.io/gh/newrelic/node-test-utilities/pull/188/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `80.07% <ø> (ø)` | | | [unit-tests-20.x](https://app.codecov.io/gh/newrelic/node-test-utilities/pull/188/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `80.07% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jsumners-nr commented 5 months ago

@bizob2828 I have addressed your feedback, but I'm rather confident it will not solve the issue going forward. I believe the problem is npm install <pkg> isn't updating package-lock.json locally (could be due to a config I have on my system).

What benefit does the package-lock.json provide us anyway? It doesn't get read when the module is installed because package managers ignore transitive lock files.