search

newrelic / node-test-utilities

Test helpers for Node.js instrumentation modules
Apache License 2.0
5 stars 15 forks source link

chore: Added instrumentation tracking to support newrelic issue 2033 #195

Closed jsumners-nr closed 6 months ago

jsumners-nr commented 6 months ago

This PR updates the minimum version of newrelic in order to utilize the instrumentation tracker instead of Object.create(null) in the agent helper.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.27%. Comparing base (4254669) to head (849bc2e).

Files Patch % Lines
lib/agent.js 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #195 +/- ## ========================================== + Coverage 80.25% 80.27% +0.01% ========================================== Files 23 23 Lines 3378 3386 +8 ========================================== + Hits 2711 2718 +7 - Misses 667 668 +1 ``` | [Flag](https://app.codecov.io/gh/newrelic/node-test-utilities/pull/195/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | Coverage Δ | | |---|---|---| | [unit-tests-16.x](https://app.codecov.io/gh/newrelic/node-test-utilities/pull/195/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `80.27% <88.88%> (+0.01%)` | :arrow_up: | | [unit-tests-18.x](https://app.codecov.io/gh/newrelic/node-test-utilities/pull/195/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `80.27% <88.88%> (+0.01%)` | :arrow_up: | | [unit-tests-20.x](https://app.codecov.io/gh/newrelic/node-test-utilities/pull/195/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `80.27% <88.88%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.