Create / config an Action that validates that a submodule contains the Catalog components

newrelic / nr1-catalog

New Relic One Catalog repo of repos

Apache License 2.0

6 stars 27 forks source link

Create / config an Action that validates that a submodule contains the Catalog components #1

Closed tangollama closed 4 years ago

tangollama commented 4 years ago

The specs for the catalog are described in detail here and usage in the proposed UI is here.

We need:

[x] a semantic version number in the package.json
[x] an nr1.json file in the root of the submodule
[x] an icon.png file in the root of the submodule
[x] a catalog/config.json file matching the linked format (containing at least two elements in the support subsection of the JSON)
[x] at least one screenshot in the catalog/screenshots directory

jbeveland27 commented 4 years ago

We're currently using semantic-release to handle versioning (via .releaserc). There are several GitHub Actions available to more or less do the same thing we're doing with CircleCi. Do we want to continue using that or switch to just detecting semantic version number in package.json?

jbeveland27 commented 4 years ago

Is the icon.png needed in the root of the submodule, or the root of a launcher? If this doc is the source of truth, we might need to add icon files to all the nerdpacks for the catalog to pick them up correctly.

jbeveland27 commented 4 years ago

Files-present-action addresses all these requirements.