search

newrelic / nr1-catalog

New Relic One Catalog repo of repos
Apache License 2.0
6 stars 26 forks source link

`semantic-release` breaking changes #288

Closed aswanson-nr closed 3 years ago

aswanson-nr commented 3 years ago

Summary

The semantic-release NPM module has been updated to v18.0.0 with a breaking change that requires Node.js v14 or higher. Semantic release v18

Most of our third party apps use this module to handle creating new releases, but do not lock down the module's version. So these workflows will now be attempting to use v18 of semantic-release.

Acceptance Criteria

To resolve this problem we need to update the Node.js version in these workflows for all the repos below to use >14.17 and lock down the semantic-release version to 18.0.0.

Affected repos

aswanson-nr commented 3 years ago

Here is a link to the update on the developer site Current: https://github.com/newrelic/developer-website/blob/develop/.github/workflows/release.yml#L129-L167 Diff: https://github.com/newrelic/developer-website/commit/82aa8aa7caee2829af676e5ec45489d0f35d3a25#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34 Note that I also removed the caching to prevent polluting the cache with different dependencies from Node 14, but that might not be applicable to these workflows.

rudouglas commented 3 years ago

The Eslint failure on the nr1-network-telemetry has bin happenin https://github.com/newrelic/nr1-network-telemetry/pull/60/checks?check_run_id=1983954280 so not sure what to do with that?

aswanson-nr commented 3 years ago

Hey @rudouglas, I started going through these and they look great! I just noticed one thing, we probably want to remove the caching step to prevent polluting the cache for other jobs. I commented on a few of the PR's, but I figured a message here would be easier for you.

aswanson-nr commented 3 years ago

@jbeveland27 Should update the template to lock down these versions as well? https://github.com/newrelic/template-nerdpack

jbeveland27 commented 3 years ago

@aswanson-nr Probably worthwhile. I'm not sure if anyone uses the template anymore, but can't hurt to update it

aswanson-nr commented 3 years ago

Quick update: All the repos that have been merged are checked off. For the few that are left:

aswanson-nr commented 3 years ago

I reached out to contributors on each repository to ask for a review and merge. Going to move this to blocked for now.

aswanson-nr commented 3 years ago

Tracking the error in graphiql-notebook here and closing this ticket.