search

newrelic / nr1-cloud-optimize

NR1 Cloud Optimize allows you to Identify right-sizing opportunities and potential savings of your AWS, GCP, and Azure instances across your cloud environment.
https://discuss.newrelic.com/t/cloud-optimizer-nerdpack/82936
Apache License 2.0
48 stars 37 forks source link

fix: support EU region of newrelic #112

Closed woehrl01 closed 1 year ago

woehrl01 commented 1 year ago

This PR fixes the detection of "dev" vs "prod", so that it also detects the EU hosted NewRelic correctly as "prod".

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

woehrl01 commented 1 year ago

Hi @Kav91 , looks like that the lint error is due to a failing script. Is there anything I should modify?

Kav91 commented 1 year ago

@woehrl01 the linter was complaining because it needed a line break, as the line was a touch too long.

I also removed the regex and use && instead as it has better performance for this case. image

nr-opensource-bot commented 1 year ago

:tada: This PR is included in version 3.23.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

woehrl01 commented 1 year ago

@Kav91 looks like there is no eu missing in the refactor.

Kav91 commented 1 year ago

@woehrl01 🤦🏾 sorry, not sure how I missed that, thanks for catching. I'm just going to trigger a release on main branch with that fix.