newrelic / nr1-cloud-optimize

NR1 Cloud Optimize allows you to Identify right-sizing opportunities and potential savings of your AWS, GCP, and Azure instances across your cloud environment.
https://discuss.newrelic.com/t/cloud-optimizer-nerdpack/82936
Apache License 2.0
50 stars 37 forks source link

Matched Instance column doesn't work for CSV export #22

Closed StephenGoodall closed 4 years ago

StephenGoodall commented 4 years ago

Description

When running Export Data from the Optimization Candidates screen, the output does not open correctly. this is because "matchedInstance" is a JSON object so the commas throw off the CSV format.

Steps to Reproduce

Click "Show Optimization Candidates" Click "Export Data" Open export.csv in Excel See that the columns stop lining up after "matchedInstance".

Expected Behaviour

Columns should line up with the header.

Relevant Logs / Console output

See how the columns go wrong after "region" image

Your Environment

Additional context

Not sure what data is supposed to be displayed there but I suggest it would just show the "type" value - will submit a PR for this accordingly, but feel free to change it if you want different information in there

devfreddy commented 4 years ago

:tada: This issue has been resolved in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: