newrelic / nr1-cloud-optimize

NR1 Cloud Optimize allows you to Identify right-sizing opportunities and potential savings of your AWS, GCP, and Azure instances across your cloud environment.
https://discuss.newrelic.com/t/cloud-optimizer-nerdpack/82936
Apache License 2.0
50 stars 37 forks source link

Include CPU and Memory values of Suggested Instance in Optimisation Candidates #31

Closed StephenGoodall closed 4 years ago

StephenGoodall commented 4 years ago

Issue #30

I haven't tested these changes out yet - wanted to check your thoughts on it first @Kav91

Let me know what you think, if it sounds sensible then perhaps it could be useful for issue 13 aswell (although t's probably getting close to a point where there are too many columns on the view), if we have the suggested CPU we could have a guess at the maxCPU and Memory based on the original instances and give some kind of projection? eg. something simple like if it was 40% on 4 CPU then it might be 80% on a 2 CPU suggested Instance, and 25% Memory usage on a 32GB might be 50% on a 16GB instance type.

Kav91 commented 4 years ago

Temporarily parking this PR as I'm about to make a large refactor in the coming weeks. Ideally I would like to make the table columns configurable and remember the users selected columns.

Kav91 commented 4 years ago

Closing PR as a large refactor has taken place, so will need to be reworked/revisited.