Tracking: refactor nerdlets/cloud-optimize-apm/cloud-optimize-apm.js

newrelic / nr1-cloud-optimize

NR1 Cloud Optimize allows you to Identify right-sizing opportunities and potential savings of your AWS, GCP, and Azure instances across your cloud environment.

https://discuss.newrelic.com/t/cloud-optimizer-nerdpack/82936

Apache License 2.0

48 stars 37 forks source link

Tracking: refactor nerdlets/cloud-optimize-apm/cloud-optimize-apm.js #39

Closed tangollama closed 3 years ago

tangollama commented 4 years ago

nerdlets/cloud-optimize-apm/cloud-optimize-apm.js contains four linting errors that are currently addressed through disabling the checks. The appropriate remediation is to refactor the code. The issues are:

[ ] calling setState in the componentDidUpdate method
[ ] async resolver to a Promise in handleParentState
[ ] async resolver to a Promise in fetchContainerPerformanceData
[ ] async resolver to a Promise in fetchHostPerformance

Kav91 commented 4 years ago

@tangollama I'll be rewriting the entire nerdpack starting next week. The work should resolve this, and #38. Leave these two with me.

tangollama commented 4 years ago

Sounds great @Kav91. When I was going through the review, I just wanted/needed to make sure I kept tabs on what we might look at when reviewing roadmap/backlogs. Thanks for the heads up.