Non-optimized instances no longer included as potential savings.

newrelic / nr1-cloud-optimize

NR1 Cloud Optimize allows you to Identify right-sizing opportunities and potential savings of your AWS, GCP, and Azure instances across your cloud environment.

https://discuss.newrelic.com/t/cloud-optimizer-nerdpack/82936

Apache License 2.0

48 stars 37 forks source link

Non-optimized instances no longer included as potential savings. #54

Closed crshanks closed 3 years ago

crshanks commented 4 years ago

Nulls, when used in a logical comparison are assigned the value 0, so a check is required to ensure optimized price is not null. This had the effect of assigning instances that are not flagged for optimization to the potential savings.

Additionally the optimizedSpend needs to be assigned to each instance for the group tiles and summary bar totals to be calculated correctly.

Fixes #53

CLAassistant commented 4 years ago

All committers have signed the CLA.

tangollama commented 3 years ago

Thanks @crshanks for the PR. Bump @Kav91 on merging this.

Kav91 commented 3 years ago

Awesome thanks for spotting and the fix @crshanks .

nr-opensource-bot commented 3 years ago

:tada: This PR is included in version 2.1.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: