search

newrelic / nr1-cloud-optimize

NR1 Cloud Optimize allows you to Identify right-sizing opportunities and potential savings of your AWS, GCP, and Azure instances across your cloud environment.
https://discuss.newrelic.com/t/cloud-optimizer-nerdpack/82936
Apache License 2.0
50 stars 37 forks source link

Regardless of cloud provider, AWS instance types are suggested #55

Closed crshanks closed 4 years ago

crshanks commented 4 years ago

When deployed from the NR App Catalog, the default cloud used for instance right size suggestions is not configurable. It is currently (2.1.0) set to "amazon" in the code.

Description

If the cloud provider is, say Azure, the suggested instance types are not Azure types, instead AWS types are provided: image

Deploying manually allows the value to be set in the code: nerdlets/cloud-optimize-core/context/data.js, by changing the optimizationDefaults.defaultCloud string from 'amazon' to your cloud provider, e.g. 'azure'.

Steps to Reproduce

Deploy the nr1-cloud-optimize NR One application through the app catalog for an account where the hosts are in the Azure cloud.

Expected Behaviour

Azure right-size suggestions provided, when the original instances are also Azure instances.

Your Environment

NR1 CLI v1.22.2 Chrome v83 MacOS Catalina v10.15.5 Cloud Optimize release 2.1.0

Additional Context

The suggested types could be based on:

Kav91 commented 4 years ago

@crshanks good catch, some of this code was ported from nimbus where you would set your desired cloud to migrate too at the beginning of the process. This was an oversight, I'll put priority on this to rework this behaviour.

Kav91 commented 4 years ago

Fixed in #b7eaf78. Will send a PR to update the app catalog version.