search

newrelic / nr1-cloud-optimize

NR1 Cloud Optimize allows you to Identify right-sizing opportunities and potential savings of your AWS, GCP, and Azure instances across your cloud environment.
https://discuss.newrelic.com/t/cloud-optimizer-nerdpack/82936
Apache License 2.0
50 stars 37 forks source link

Add optional chaining to engine var #99

Closed LizBaker closed 2 years ago

LizBaker commented 3 years ago

Ran into a lot of local issues around objects not being mutable so I ended up using lodash's deep clone function which fixed that. Once that was in I got to the error referenced in https://github.com/newrelic/nr1-cloud-optimize/issues/97 which was around the engine variable not being defined. Added optional chaining to the variable and can now get the entities to load (albeit slowly 😅 )

To test:

  1. I think it's probably best to run it locally and make sure to nr1 nerdpack:uuid -gf from an nr1 profile associated with account 1 (i can slack you the uuid if you don't have that profile set up)
  2. You should be able to click on amazon rds and have that screen load. it takes a bit to load the loading screen unfortunately, and once it does it can hang on 100% for a few seconds, but ultimately it should load and not permanently hang
CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

jpvajda commented 2 years ago

@LizBaker I tried to test this out follow the steps and I can't get anything to load locally I just get a spinner. my staging account is associated with account 1

LizBaker commented 2 years ago

@jpvajda i'm curious where you see a spinner in the app, is it trying to load it at all? after you click on amazon rds?

jpvajda commented 2 years ago

@LizBaker I actually couldn't even load the app interface at all. Let me test it out again. 🤔

jpvajda commented 2 years ago

oh I figured it out I ran nr1 profiles:list and It looks like I only have a single account profile, that isn't associated with account 1, so It did start up ok, but on that account i have no RDS instances to test.

nr-opensource-bot commented 2 years ago

:tada: This PR is included in version 2.9.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: