search

newrelic / nr1-community

An open-source library of useful components for building on New Relic One's programmability platform.
https://developer.newrelic.com
Apache License 2.0
11 stars 12 forks source link

feat: add functions to empty state proptypes #60 #72

Closed MattIGolden closed 4 years ago

MattIGolden commented 4 years ago

Allows for functions on any of the EmptyState props

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: MattIGolden
:x: Matt Golden

Matt Golden seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

danielgolden commented 4 years ago

Whoa, sorry for the delay. I'm just now seeing this. I'm going to test this out and then will review it/leave feedback. Thanks for submitting this, @MattIGolden!

p.s. this CLA issue is really weird and I don't know why it's happening. @jbeveland27 Any idea why it might think he's not a GitHub user?

danielgolden commented 4 years ago

Note to self: @danielgolden if this solution sticks, then we'll also need the props table and docs page updated with these changes.