When my APM service has a unique name that doesn't return anything from the GitHub suggestion search, the "Provide your own repository URL" field doesn't appear, so I can't manually configure it.
Steps to Reproduce
Go to the Entity Explorer.
Click on an APM Service that has a very unique name, such as "PROD-Bixel-NewLH",
Go to the GitHub Repo app
Go to the Repository Tab
I get a "An error occurred: Error fetching suggestions" and no "Provide your own repository URL".
Expected Behaviour
"Provide your own repository URL" field should appear even if no suggestions are found.
Description
When my APM service has a unique name that doesn't return anything from the GitHub suggestion search, the "Provide your own repository URL" field doesn't appear, so I can't manually configure it.
Steps to Reproduce
Expected Behaviour
"Provide your own repository URL" field should appear even if no suggestions are found.
Relevant Logs / Console output
I can see the network request to github: https://api.github.com/search/repositories?q=in%3Aname%20in%3Areadme%20in%3Adescription%20PROD%20Bixel-NewLH
It returns a 200 with this response:
Your Environment
I installed this via the "Application Catalog" app on the New Relic ONE dashboard and not through the CLI.
It says that it's: Release date: January 15, 2020 Version 0.4.0
Additional context
On the master branch in https://github.com/newrelic/nr1-github/blob/master/nerdlets/github-about/repo-picker.js, the render function returns if there is an error:
So it never renders the
this.renderSuggestions()
which handles the custom url field (this.renderCustomUrlRow()
)If no suggestions are found, that's an error condition in
loadSuggestions()
: