search

newrelic / nr1-graphiql-notebook

NR1 Graphiql Notebook allows you to explore New Relic data via our GraphQL API and share notebooks with colleagues.
https://discuss.newrelic.com/t/graphiql-notebook-nerdpack/82933
Apache License 2.0
9 stars 9 forks source link

Notes multi-line textbox (<TextField>) behaving strangely #8

Closed mattbaker closed 5 years ago

mattbaker commented 5 years ago

A notes field that's already populated with content that spans more than one line in the text area will be cut off, and the size of the text area will not automatically expand to fit. Typing in the box will cause the textarea to reset and size accordingly.

This may be a bug in the UI component itself, so worth reaching out to the NR1 SDK development team

danielgolden commented 5 years ago

@mattbaker I do think think this an issue with the component itself. The <textarea> has row="1" by default and when you edit the contents of the <textarea> a height attribute is added to it to compensate for the actual needed height for the contents.

It seems that either the height attribute should be added when the component is first rendered (which is not the way it currently functions) or the row attribute should be removed.

mattbaker commented 5 years ago

Agreed, seems like curious behavior. @mjesun — what are your thoughts on this? Am I using the component incorrectly or is this an improvement in the SDK we can make?

mjesun commented 5 years ago

@mattbaker this looks like a bug in our TextField component. I will report it into our Jira and try taking a look tomorrow.

mattbaker commented 5 years ago

Thank you @mjesun!

mjesun commented 5 years ago

The fix is in staging BTW :)