newrelic / nr1-groundskeeper

NR1 Groundkeeper allows you to generate a live view of all the APM agents across your Services.
https://discuss.newrelic.com/t/groundskeeper-nerdpack/84168
Apache License 2.0
7 stars 20 forks source link

[Fix] distributed tracing reporting for Go and PHP #120

Closed adammarshallNR closed 1 year ago

adammarshallNR commented 1 year ago

Added the keys for DT reported by Go and PHP and changed the feature check function to check if featuresList is an array, then loops through, if not, proceeds as before.

It appears Logs in Context isn't reporting properly in some cases too, so I will keep working to fix that as well, building on this (assuming this is ok).

My first fix and PR apologies for any issues!!

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

amit-y commented 1 year ago

👋 @adammarshallNR - Thanks for putting in this PR. My apologies for the delay in getting it reviewed!

We use the AngularJS style of commit messages. The build process relies on that, and so if you could get the recommended changes in, with that style of commit message, that would be great!