newrelic / nr1-neon

NR1 Neon allows you to create a status board based on New Relic alert statuses or event values.
https://discuss.newrelic.com/t/neon-alerting-nerdpack/83272
Apache License 2.0
3 stars 14 forks source link

enable working with percentiles #40

Closed dulcineapena1 closed 3 years ago

dulcineapena1 commented 4 years ago

Releted to #39 Add the hability to work with percentiles attributes values.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

dulcineapena1 commented 4 years ago

Hello @glitton Thanks for your answer. Unfortunately I could not replicate that error that you mention... I will appreciate if you could tell me more about where did you get the error...

Talking about the explanation that you ask me, I notice when I try to work with percentiles, I got a blank cell instead of the bullet or the value. For example if I select an event type SystemSample, attribute median(cpuSystemPercent), I will have a blank cell in my board; and in case I add a comparison less than 1, my entire board will crash with the message 'Oops! Something went wrong.' I mean, I would expect to have a bullet in my board, similar that the ones you get when you are working with another type of attribute. I don't know if there is a good thing to have this, or maybe Neon board is not supposed to work with percentiles.

Thanks for your time!

danielgolden commented 4 years ago

@glitton Any thoughts on @dulcineapena1's latest comment?

jpvajda commented 3 years ago

This seems like a stale PR, so I'll close unless someone can confirm this is still being worked on.

dulcineapena1 commented 3 years ago

This seems like a stale PR, so I'll close unless someone can confirm this is still being worked on.

@jpvajda You can close this PR, I was working on it few months ago, but I am not longer on it because I couldn't find the requested error... I thought this could be a usefull functionality but maybe this is not that is completely necesary for now. Thank you.

jpvajda commented 3 years ago

@dulcineapena1 ok thanks for confirming.