search

newrelic / nr1-network-telemetry

NR1 Network Telemetry gives you real time IPfix and Sflow visualization of network data passing through your system.
https://discuss.newrelic.com/t/network-telemetry-nerdpack/90561
Apache License 2.0
12 stars 11 forks source link

feat: limit width of src in network summary table #28

Closed danielgolden closed 4 years ago

danielgolden commented 4 years ago

I'm confident that this little change will prevent the source column in the network telemetry table from expanding to a width that causes scroll overflow or worse:

Captura de Pantalla 2020-01-28 a la(s) 1 24 15 p  m

Unfortunately I haven't actually been able to test it because not accounts are showing up for me in the account picker and I'm not sure why. @jthurman42 Do you know off of the top of your head why this might be? I'd like to test this out before it gets merged in.

claassistantio commented 4 years ago

CLA assistant check
All committers have signed the CLA.

tangollama commented 4 years ago

@danielgolden, you need to add .prettierrc.js to your PR.

danielgolden commented 4 years ago

@tangollama This project already has a prettier config file: prettierrc.yaml.

danielgolden commented 4 years ago

CircleCI is complaining about there not being a prettier config file, but that's because it's looking for a .prettierrc.js file when the prettier config file for this project is a .yaml file. Going to merge this.

devfreddy commented 4 years ago

:tada: This PR is included in version 0.3.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: