newrelic / nr1-observability-maps

NR1 Observability Maps allows you to create an observability map based on any of the data available in New Relic.
https://discuss.newrelic.com/t/nr1-observability-maps-nerdpack/93091
Apache License 2.0
12 stars 11 forks source link

Error Screen if the connected entities screen is open for too long #60

Open twcallaghan opened 3 years ago

twcallaghan commented 3 years ago

When you click on "view connected entities" and then leave that screen open in a tab in the foreground or background, if it is left open for too long then it gives an error screen as seen below. In the error box it says "TypeError: Cannot read property 'filter' of undefined" I redacted much of the screenshot due to security concerns as this is from an observability map used with the organization I am working at. image-2021-03-02-12-10-32-888-FINAL

Steps to Reproduce

It seems like this happens from just keeping the observability maps open. Open up the "connected entities" of a node and then leave it there for an extended period of time.

Expected Behaviour

It should keep the connected entities open with the observability map to the left. There should be no reason that there should be an error as it is just viewing connected entities. The connections aren't changing in the backend either.

Relevant Logs / Console output

In the error box: "TypeError: Cannot read property 'filter' of undefined"

Your Environment

jpvajda commented 3 years ago

@twcallaghan I was trying to reproduce this bug buy couldn't. It seems the refresh rate setting is sending a request to refresh the map, I had mine set for 30 sec refresh and I continually get the refresh to succeed. Curious, how long are you leaving a map open for this error to occur?

Refreshing... (timer: 30000ms) 1617039943553 60c04cc2-59d2-416a-a896-e5ff6ef28bbc--observability-maps-nerdlet.js:1:26701
decorated mapData 
Object { linkData: {…}, nodeData: {…} }
60c04cc2-59d2-416a-a896-e5ff6ef28bbc--observability-maps-nerdlet.js:1:32232
Refreshing... (timer: 30000ms) 1617039973554 60c04cc2-59d2-416a-a896-e5ff6ef28bbc--observability-maps-nerdlet.js:1:26701
decorated mapData 
Object { linkData: {…}, nodeData: {…} }
60c04cc2-59d2-416a-a896-e5ff6ef28bbc--observability-maps-nerdlet.js:1:32232
Refreshing... (timer: 30000ms) 1617040003556 60c04cc2-59d2-416a-a896-e5ff6ef28bbc--observability-maps-nerdlet.js:1:26701
decorated mapData 
Object { linkData: {…}, nodeData: {…} }
60c04cc2-59d2-416a-a896-e5ff6ef28bbc--observability-maps-nerdlet.js:1:32232
Refreshing... (timer: 30000ms) 1617040033558 60c04cc2-59d2-416a-a896-e5ff6ef28bbc--observability-maps-nerdlet.js:1:26701
decorated mapData 
Object { linkData: {…}, nodeData: {…} }
twcallaghan commented 3 years ago

@jpvajda I would have had to leave the window open for at least over an hour. I mean a long time like I leave the tab in the background for quite a while. It is on an account under a corporation that uses it with SSO, so do you think that the NR SSO could be requiring a reload to ensure that I am still logged in/secure?

jpvajda commented 3 years ago

@twcallaghan it's quite possible our NR SSO provider has a logout for inactivity that invalidates all sessions. I can ask around to confirm.

jpvajda commented 3 years ago

@twcallaghan do you happen to know which Identity Provider you use? https://docs.newrelic.com/docs/accounts/accounts/saml-single-sign/saml-service-providers/

twcallaghan commented 3 years ago

@jpvajda My bad for taking so long to respond! Midterms have been killing me!

Microsoft SSO is what the org I am with uses for everything.

jpvajda commented 3 years ago

@twcallaghan Thanks! I've reached out a team internally that may be able to answer this question, I'll let you know what I hear back.

jpvajda commented 3 years ago

@twcallaghan here is the response:

"we do enforce a idle timeout as well as a max session duration. This is something that should be configurable on the account in the session settings. Note that for SSO the max session duration we allow is 30 days. The idle timeout can be up to that max duration."

So an admin of New Relic can check your org's SSO settings, where you should be able to configure this setting.

twcallaghan commented 3 years ago

@jpvajda Thanks for looking into this for me!

I figured this is what must be causing it, but I just double checked and we have our settings for SSO enabled so that they should never timeout. Here is a screenshot of the settings we have for all accounts at our org: image

So, theoretically it isn't that, and I know it isn't the VPN disconnecting because I have had a stable VPN connection from opening to having the tab get the error shown.

Any other ideas? Thanks!

jpvajda commented 3 years ago

@twcallaghan Ok thanks for sharing this info, at this point it seems like an app bug, so I'll put this back in todo This app is opensource so I'm hoping someone in the app community can pick it up for resolution.

twcallaghan commented 3 years ago

@jpvajda Thanks! I am moving on from my current employment in a couple of weeks so I will make sure to pass this bug onto those on my team. Your team and this community has been amazing in the past! Thanks again!

jpvajda commented 3 years ago

@twcallaghan Thanks for kind words. Good luck on your next job!