Closed jpvajda closed 2 years ago
@rsamanez Can you add this issue to the sprint. We should be able to get this resolved as part of our efforts to get your latest work back into the catalog
@JimHagan i did some work on this today and think i've resolved the build issues, but would appreciate a review to make sure
cc @jpvajda
@rsamanez might be able to provide a review as well on this PR.https://github.com/newrelic/nr1-pathpoint/pull/16. I've also checked it out and had a comment.
I tested this PR, after running nr1 nerdpack:uuid -gf
😉 I'm not seeing any application load locally. @rudouglas All I see is the spinner component.
That's weird, I'm seeing results and i had to run nr1 nerdpack:uuid -gf
🍔 Are you seeing this error in the DevTools console:
Uncaught (in promise) Error: TypeError: Cannot assign to read only property 'status_on_off' of object '#<Object>'
I think that might be down to the Node version, try using Node 12 and reinstalling everything
@rudouglas it works now! Thanks for the suggestions, Stark Industries is back online.
I am Iron Man...duh duh duh duh dit do Iron Man 🦇
Description
We were trying to update this app in the cantlog and it was failing, we then discovered it doesn't run locally so we'll need to spend some time investigating this. This app also seems to have it's own support system so not sure on that.
Catalog Merge Issue
There is an issue with the tests, they pass in a specific version number which is behind the current version of the app. I think just updating the relevant tests, as well as the sample JSON files to match
1.1.x
will suffice. The Schema checks to see if the first 2 numbers in the configpathpointVersion
are the same as the current app versionBuild Issue
Seeing the following error when built locally: