newrelic / nr1-slo-r

NR1 SLO-R allows you to define, calculate and report on service-level objective (SLO) attainment.
https://discuss.newrelic.com/t/track-your-service-level-objectives-with-the-slo-r-nerdpack/90046
Apache License 2.0
21 stars 21 forks source link

feat: Add support for calculated latency SLOs #117

Closed ghost closed 4 years ago

ghost commented 4 years ago

Adds support for calculating Latency SLOs like Error SLOs. Resolves #112 by adding a new option called "Calculated Latency" that appears as a separate indicator. Instead of defects, it accepts a maximum duration; any transactions above this limit are counted against the SLO.

To Do:

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

tangollama commented 4 years ago

@andrewseling, thanks for opening this PR. When you're ready for a review, please make sure to sign the CLA.

cc: @ricegi

ricegi commented 4 years ago

thanks team - I am reviewing and merging today.

ghost commented 4 years ago

@ricegi Feel free to review and provide feedback on the approach, but this isn't 100% done yet. Still need to investigate why the SLO query always returns 100%. Should be ready for review/merge later this week or early next week.

ghost commented 4 years ago

Calculations are fixed, but I can't create latency_budget and error_budget SLOs at the same time. Think it's something silently failing with Formik/Yup. Going to keep working on that.

ghost commented 4 years ago

@ricegi Ready for you to review.

ghost commented 4 years ago

@ricegi @tangollama Not to nag, but any idea when you will be able to review this? We are working on a SLO rollout to a variety of pilot teams at the moment, and would like to include latency SLOs to avoid extra touches.

Thanks!

ricegi commented 4 years ago

Hey @andrewseling - not a nag at all - and sorry for the delay here. I had issues merging the PR and had to put it to the side while some other work was done. I am actively looking to get this PR done today / tomorrow.

nr-opensource-bot commented 4 years ago

:tada: This PR is included in version 1.7.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: