newrelic / nr1-slo-r

NR1 SLO-R allows you to define, calculate and report on service-level objective (SLO) attainment.
https://discuss.newrelic.com/t/track-your-service-level-objectives-with-the-slo-r-nerdpack/90046
Apache License 2.0
21 stars 21 forks source link

NRQL query for alert based SLO not correct #53

Closed jeffrey-hines closed 4 years ago

jeffrey-hines commented 4 years ago

Description

After defining SLO it doesn't work. When viewing the details of the SLO the NRQL has WHERE policy_name IN (’’) which obviously won't work.

Steps to Reproduce

Define a SLO

Expected Behaviour

Should generate the correct NRQL.

Relevant Logs / Console output

Your Environment

Additional context

image

ricegi commented 4 years ago

@jeffrey-hines - sorry in the delay in getting this reviewed. It looks like we made a change in the array implementation of the alerts - adding an array of objects rather than a simple array of string Alert names. The result when you click on the info button is to not recognize the simple array and show a blank.

To fix you would need to delete the defined SLO document and recreate it. The latest version of SLO/R should use the correct model and implement it correctly.

I am going to review the consistency of the embedded arrays in the SLO document to - since it is a versioned schema we should be able to understand what schema we're loading and make the appropriate modifications the SLO and resave in a new version. I think we missed the opportunity to code that check before we shipped.

If there is any chance you could check that the "slo_r_version": is "1.0.1", I would appreciate it - it seems that version wasn't rev'ed when the change to including an object was made.

And thank you for reporting this issue - I'll update the community thread to point to this bug report.

jeffrey-hines commented 4 years ago

Looks like my version is 1.4.3

ricegi commented 4 years ago

thank you Jeff - I think this is the root of the issue.

ricegi commented 4 years ago

Should be addressed with rel 1.4.6