newrelic / nr1-status-pages

NR1 Status Pages allows you to collect and display the statuses of key dependencies in one place.
https://github.com/newrelic/nr1-status-pages/discussions
Apache License 2.0
36 stars 22 forks source link

Handle http URLs gracefully #158

Open aso1124 opened 1 year ago

aso1124 commented 1 year ago

Summary

URLs using http instead of https will be blocked by the browser due to a mixed content error. Statuses set up using an http URL will fail - currently, the UI will show a generic error that doesn't explain the source of the problem (it is only available by looking at the browser console).

Desired Behaviour

At a minimum, check for URLs using HTTP only, and block those URLs from being set up as a service.

When an HTTP URL is detected, the user should be presented with an informative message in the Add Service modal indicating the cause of the problem.

The user should be advised to test the URL with HTTPS - if it works, they can use the HTTPS URL; if it doesn't work, the URL can't be used in Status Pages.

shahramk commented 9 months ago

11-13-23

added TextFieldWrapper component to status-page.js so that I can use validationText property when a service is being edited in main-page.js check the url for the service logo to ensure it uses secure url 3 hrs