[Meta]: Project Outstanding Items

[devfreddy]

Geo Ops Workloads Outstanding Items

Feat

• [x] NRQL, both input and rendering on the map
• [x] Marker hovers/clicks and side panels (Daniel, Freddy)
• [x] Display detailpanel when table row is clicked
• [x] Feat(View Map): Filter by Region. Keep in mind potential future need of Country/Municipality
• [x] Pass status of each MapLocation down to the MapMarker. Pull calculateStatus out of into , figure out status, change MapLocation data
• [x] Favorites
• [x] Highlight visually the active marker

Fix

• [x] favorite sorting is broken (sometimes)
• [x] limit description height in popover
• [x] navigate to empty state after deleting all maps
• [x] Navigation state changes between file upload and main nerdlet
• [x] Retrieve Incidents for Entities (Freddy)
• [x] styling on map location data page (Daniel)
• [x] flashes, are we allowed to do this (a side panel) without <Modal> ?
• [x] https://github.com/newrelic/nr1-workload-geoops/issues/37
• [ ] Styling:
  • [x] Style type-ahead
  • [x] Style upload file nerdlet
  • [x] Style account picker
  • [ ] Remove ability to navigate through getting started steps if you haven't finished the step before
• [x] remove "submit" button, just utilize continue button
• [x] clicking on "continue" should take you to View Map

Backlog

• [ ] Research: can we utilize a <Dropdown label="My Account 1"> based from the platform team inside a form
• [ ] Identify components for nr1-community
• [ ] Feat: Ability to choose chart component for side panel for a map location (Backlog/Future)
• [ ] testing file upload schema failures (Backlog)
• [ ] Expand a timeline item by default depending on which was clicked in the detail panel. (Dependant on newrelic/nr1-community#55)
• [ ] Feat: Edit Map and Edit Map Location screens (Backlog)

The "label" prop is deprecated. If you are using as a form component, use instead (due 12/31/2020). The new is based on Dropdown.

danielgolden commented 4 years ago

This one is puzzling me:

fix: flashes, are we allowed to do this (a side panel) without ?

This flash is new as of a week or so. When I first styled the the detail panel and added its visibility to the state to show and hide it, it worked without issue. I even tested it to get the animation right, so I'm sure it was working at some point because now you don't see any animation at all whereas before you did.

I think the issue is calling setState() from the openDetailPanel function. That.. doesn't make sense to me though, so I'm going to keep digging. I may drop it and come back after tackling other bigger issues.

devfreddy commented 4 years ago

For posterity's sake - the flashes issue with the DetailPanel was caused by <AlertableEntitiesByGuidsQuery> having some bad begin_time and end_time defaults set in its render() method. The setState() called when "opening" the DetailPanel caused a re-render and because we were utilizing Date.now() in the render method a change in the children prop.

Solved by setting the default higher in the component tree (in ViewMap), and also utilizing the PlatformStateContext.Consumer (if the user sets the timeRange themselves).

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[danielgolden]

This one is puzzling me:

fix: flashes, are we allowed to do this (a side panel) without ?

This flash is new as of a week or so. When I first styled the the detail panel and added its visibility to the state to show and hide it, it worked without issue. I even tested it to get the animation right, so I'm sure it was working at some point because now you don't see any animation at all whereas before you did.

I think the issue is calling setState() from the openDetailPanel function. That.. doesn't make sense to me though, so I'm going to keep digging. I may drop it and come back after tackling other bigger issues.

[devfreddy]

For posterity's sake - the flashes issue with the DetailPanel was caused by <AlertableEntitiesByGuidsQuery> having some bad begin_time and end_time defaults set in its render() method. The setState() called when "opening" the DetailPanel caused a re-render and because we were utilizing Date.now() in the render method a change in the children prop.

Solved by setting the default higher in the component tree (in ViewMap), and also utilizing the PlatformStateContext.Consumer (if the user sets the timeRange themselves).