search

newrelic / nr1-workload-geoops

NR1 Workload Geo Ops aligns Workload data (or other Entities) in a Geographic management console.
Apache License 2.0
4 stars 19 forks source link

Pull the comparison percentage into the detail panel. It's static rn. #42

Open danielgolden opened 4 years ago

danielgolden commented 4 years ago
Captura de Pantalla 2020-03-18 a la(s) 3 26 28 p  m
devfreddy commented 4 years ago

@danielgolden I noticed this as well, for now I've commented it out and left some notes:

We don't have this data. We built the data fetching into so it only queries for those points that are visible We would need to re-execute the query for this MapLocation, or pull up the data fetching out of

It might make the most sense to just re-execute the query vs. trying to pass it down, this way if they leave a detail panel open, because they're honed in on that one MapLocation, we can independently update it.

danielgolden commented 4 years ago

@devfreddy IMO, this a nice to have. If it ends up being enough work, feel free to just move this out of the milestone. What do you think?

devfreddy commented 4 years ago

Agreed, before spending too much more time on it, I'd like to wait for additional feedback on the detail panel.

tangollama commented 4 years ago

I believe @danielgolden is referencing bringing this element (https://github.com/newrelic/nr1-workload-geoops/blob/57a340a73cd68d0439f817418d1d6a8d901767e6/nerdlets/geo-ops-nerdlet/GeoMap.js#L293-L299) into this component (https://github.com/newrelic/nr1-workload-geoops/blob/57a340a73cd68d0439f817418d1d6a8d901767e6/nerdlets/shared/components/DetailPanel.js#L196).

@danielgolden pleas confirm.

danielgolden commented 4 years ago

Yes, @tangollama, that is correct.